Fix or suppress some https://errorprone.info/bugpattern/AnnotateFormatMethod warnings.

Also, suppress https://errorprone.info/bugpattern/ThreadPriorityCheck in `ThreadFactoryBuilderTest`.

RELNOTES=n/a
PiperOrigin-RevId: 850082699

Author: cpovirk

android/guava-testlib/src/com/google/common/collect/testing/Platform.java

@@ -17,6 +17,7 @@
 package com.google.common.collect.testing;
 
 import com.google.common.annotations.GwtCompatible;
+import com.google.errorprone.annotations.FormatMethod;
 import java.util.Locale;
 
 /**
@@ -37,6 +38,7 @@ static void checkCast(Class<?> clazz, Object obj) {
     Object unused = clazz.cast(obj);
   }
 
+  @FormatMethod
   static String format(String template, Object... args) {
     return String.format(Locale.ROOT, template, args);
   }

android/guava-testlib/src/com/google/common/collect/testing/testers/Platform.java

@@ -17,6 +17,7 @@
 package com.google.common.collect.testing.testers;
 
 import com.google.common.annotations.GwtCompatible;
+import com.google.errorprone.annotations.FormatMethod;
 import java.util.Locale;
 
 /**
@@ -28,6 +29,7 @@
 final class Platform {
 
   /** Format the template with args, only supports the placeholder {@code %s}. */
+  @FormatMethod
   static String format(String template, Object... args) {
     return String.format(Locale.ROOT, template, args);
   }

android/guava-testlib/src/com/google/common/testing/GcFinalization.java

@@ -22,6 +22,7 @@
 import com.google.common.annotations.GwtIncompatible;
 import com.google.common.annotations.J2ktIncompatible;
 import com.google.errorprone.annotations.DoNotMock;
+import com.google.errorprone.annotations.FormatMethod;
 import com.google.j2objc.annotations.J2ObjCIncompatible;
 import java.lang.ref.WeakReference;
 import java.util.Locale;
@@ -316,6 +317,7 @@ protected void finalize() {
     System.runFinalization();
   }
 
+  @FormatMethod
   private static RuntimeException formatRuntimeException(String format, Object... args) {
     return new RuntimeException(String.format(Locale.ROOT, format, args));
   }

android/guava-tests/test/com/google/common/collect/FauxveridesTest.java

@@ -25,6 +25,7 @@
 
 import com.google.common.base.Function;
 import com.google.common.base.Joiner;
+import com.google.errorprone.annotations.FormatMethod;
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
 import java.lang.reflect.TypeVariable;
@@ -289,6 +290,7 @@ public String apply(Type from) {
         }
       };
 
+  @FormatMethod
   private static String rootLocaleFormat(String format, Object... args) {
     return String.format(Locale.ROOT, format, args);
   }

android/guava-tests/test/com/google/common/math/DoubleUtilsTest.java

@@ -22,6 +22,7 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.junit.Assert.assertThrows;
 
+import com.google.errorprone.annotations.FormatMethod;
 import java.lang.reflect.Method;
 import java.math.BigInteger;
 import junit.framework.TestCase;
@@ -76,6 +77,7 @@ public void testOneBits() {
     assertEquals(DoubleUtils.ONE_BITS, Double.doubleToRawLongBits(1.0));
   }
 
+  @FormatMethod
   private static void failFormat(String template, Object... args) {
     fail(String.format(template, args));
   }

android/guava-tests/test/com/google/common/util/concurrent/ThreadFactoryBuilderTest.java

@@ -21,6 +21,7 @@
 import static org.junit.Assert.assertThrows;
 
 import com.google.common.testing.NullPointerTester;
+import com.google.errorprone.annotations.FormatMethod;
 import java.lang.Thread.UncaughtExceptionHandler;
 import java.util.Locale;
 import java.util.concurrent.ThreadFactory;
@@ -180,6 +181,8 @@ public void testThreadFactory() throws InterruptedException {
     boolean THREAD_DAEMON = false;
     ThreadFactory backingThreadFactory =
         new ThreadFactory() {
+          // We need to test that we don't override the value set by the factory.
+          @SuppressWarnings("ThreadPriorityCheck")
           @Override
           public Thread newThread(Runnable r) {
             Thread thread = new Thread(r);
@@ -213,6 +216,7 @@ public void testNulls() {
     npTester.testAllPublicInstanceMethods(builder);
   }
 
+  @FormatMethod
   private static String rootLocaleFormat(String format, Object... args) {
     return String.format(Locale.ROOT, format, args);
   }

android/guava/src/com/google/common/base/Platform.java

@@ -78,7 +78,8 @@ static String nullToEmpty(@Nullable String string) {
     return stringIsNullOrEmpty(string) ? null : string;
   }
 
-  static String lenientFormat(@Nullable String template, @Nullable Object @Nullable ... args) {
+  static String lenientFormat(
+      @Nullable String template, @Nullable Object @Nullable ... args) {
     return Strings.lenientFormat(template, args);
   }