This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Add UsageMetadata to GenerateContentResponse #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments to the fields of GenerateContentResponse and UsageMetadata.
hsubox76
reviewed
May 3, 2024
Collaborator
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
Thanks for remembering to do the docs, forgot to check that on the last PR!
Can you also add a changeset? Minor since it changes the API.
packages/main/types/responses.ts
Outdated
| /** Candidate responses from the model. */ | ||
| candidates?: GenerateContentCandidate[]; | ||
| /** | ||
| * A set of the feedback metadata the prompt specified in |
Collaborator
There was a problem hiding this comment.
I know this is from the proto, but it's kind of garbled, maybe try using the proto comment next to the property which I think is more clear: https://source.corp.google.com/piper///depot/google3/google/ai/generativelanguage/v1main/generative_service.proto;l=444
hsubox76
reviewed
May 3, 2024
Collaborator
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
Looks good, can you just add a changeset (minor)?
Collaborator
Author
|
Whoops, yep! |
hsubox76
approved these changes
May 3, 2024
This was referenced Jun 6, 2024
This was referenced Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the UsageMetadata payload to GenerateContentResponse.