Skip to content

Commit 0bbb666

Browse files
hirochachachadavecheney
authored andcommitted
cmd/go: fix file leak in TestBuildmodePIE
Change-Id: Ifeb93f6dc75fb5f90d595211fb0f97a89bf74526 Reviewed-on: https://go-review.googlesource.com/64530 Reviewed-by: Dave Cheney <[email protected]> Run-TryBot: Dave Cheney <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent c40579a commit 0bbb666

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/cmd/go/go_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4474,6 +4474,7 @@ func TestBuildmodePIE(t *testing.T) {
44744474
if err != nil {
44754475
t.Fatal(err)
44764476
}
4477+
defer f.Close()
44774478
if f.Type != elf.ET_DYN {
44784479
t.Errorf("PIE type must be ET_DYN, but %s", f.Type)
44794480
}
@@ -4482,6 +4483,7 @@ func TestBuildmodePIE(t *testing.T) {
44824483
if err != nil {
44834484
t.Fatal(err)
44844485
}
4486+
defer f.Close()
44854487
if f.Flags&macho.FlagDyldLink == 0 {
44864488
t.Error("PIE must have DyldLink flag, but not")
44874489
}

0 commit comments

Comments
 (0)