Feature/list inactive topics (#15)

* added list empty topics to lister interface and test lister users

* upgraded sarama version to 1.27.2 and updated corresponding dependencies

* added implementation to fetch empty Topics and relevant tests

* add vs code confs to gitignore
reformat list topic and mockclusteradmin.go

* changes to use time pacakge instead of dealing with int64

* refactored tests and sarama client to have simpler interfaces
Moved size filtering logic to topic.go

* pipelined and added context to coordinate quiting of go routines

* bug fix on race condition in topic selection

* added goroutine leak check

* elaborated size flag documentation

* update circleci image to go1.13

* fixed goroutine leak by adding select case on channel enqueing
reduced cyclometric complexity by extracting out helper functions

* remove working directory for circleci build

* added github actions config, deleted circle ci conf

* fixed arbitarily failing test for listconsumer


Co-authored-by: punit-kulal <[email protected]>

Author: punit-kulal

.circleci/config.yml

@@ -0,0 +1,45 @@
+name: pull-request
+on:
+  pull_request:
+jobs:
+  build:
+    name: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: setup-go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '^1.13.1'
+      - name: setup-project
+        run: make setup
+      - name: build
+        run: |
+          env GO111MODULE=on go mod verify
+          env GO111MODULE=on make clean build
+  test: 
+    name: test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: setup-go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '^1.13.1'
+      - name: setup-project
+        run: make setup
+      - name: test
+        run: make test
+  golangci:
+    name: golangci
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: setup-go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '^1.13.1'
+      - name: setup-project
+        run: make setup
+      - name: lint
+        run: make golangci

.github/workflows/pull-request.yml

@@ -4,3 +4,5 @@ vendor/
 *.swp
 out/
 coverage*
+.vscode/
+bin/

.gitignore

@@ -76,6 +76,7 @@ run:
   skip-dirs:
     - test/testdata_etc
     - pkg/golinters/goanalysis/(checker|passes)
+    - pkg/io #inbuilt package throws permission error, hence excluded
   tests: false
 
 issues:

.golangci.yml

@@ -44,8 +44,8 @@ vet:
 	go vet ./...
 
 golangci:
-	GO111MODULE=off go get -v github.com/golangci/golangci-lint/cmd/golangci-lint
-	golangci-lint run -v --deadline 5m0s
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b bin/ v1.30.0
+	bin/golangci-lint run -v --deadline 5m0s
 
 test-coverage:
 	mkdir -p ./out

Makefile

@@ -55,6 +55,11 @@ kat topic list --broker-list <"broker1:9092,broker2:9092"> --replication-factor
 kat topic list --broker-list <"broker1:9092,broker2:9092"> --last-write=<epoch time> --data-dir=<kafka logs directory>
 ```
 
+* List topic with size less than or equal to given size
+```
+kat topic list --broker-list <"broker1:9092,broker2:9092"> --size=<size in bytes>
+```
+
 Topic throughput metrics or last modified time is not available in topic metadata response from kafka. Hence, this tool has a custom implementation of ssh'ing into all the brokers and filtering through the kafka logs directory to find the topics that were not written after the given time. 
 
 ### Describe Topics

README.md

@@ -28,8 +28,10 @@ func TestListGroupsReturnsSuccess(t *testing.T) {
 
 	consumerGroupsMap := map[string]string{"consumer1": "", "consumer2": ""}
 	mockConsumer.On("ListConsumerGroups").Return(consumerGroupsMap, nil)
-
-	mockConsumer.On("GetConsumerGroupsForTopic", []string{"consumer1", "consumer2"}, "").Return(mockChannel, nil)
+	validateParams := func(token []string) bool {
+		return (token[0] == "consumer1" && token[1] == "consumer2") || (token[0] == "consumer2" && token[1] == "consumer1")
+	}
+	mockConsumer.On("GetConsumerGroupsForTopic", mock.MatchedBy(validateParams), "").Return(mockChannel, nil)
 
 	err := admin.ListGroups("")