refactor options to be structs + interface

Author: MKrupauskas

dnshostprovider.go

@@ -10,16 +10,29 @@ import (
 
 const _defaultLookupTimeout = 3 * time.Second
 
+type lookupHostFn func(context.Context, string) ([]string, error)
+
 // DNSHostProviderOption is an option for the DNSHostProvider.
-type DNSHostProviderOption func (*DNSHostProvider)
+type DNSHostProviderOption interface {
+	apply(*DNSHostProvider)
+}
+
+type lookupTimeoutOption struct {
+	timeout time.Duration
+}
 
 // WithLookupTimeout returns a DNSHostProviderOption that sets the lookup timeout.
 func WithLookupTimeout(timeout time.Duration) DNSHostProviderOption {
-	return func(provider *DNSHostProvider) {
-		provider.lookupTimeout = timeout
+	return lookupTimeoutOption{
+		timeout: timeout,
 	}
 }
 
+func (o lookupTimeoutOption) apply(provider *DNSHostProvider) {
+	provider.lookupTimeout = o.timeout
+}
+
+
 // DNSHostProvider is the default HostProvider. It currently matches
 // the Java StaticHostProvider, resolving hosts from DNS once during
 // the call to Init.  It could be easily extended to re-query DNS
@@ -30,7 +43,7 @@ type DNSHostProvider struct {
 	curr       int
 	last       int
 	lookupTimeout time.Duration
-	lookupHost func(context.Context, string) ([]string, error) // Override of net.LookupHost, for testing.
+	lookupHost lookupHostFn // Override of net.LookupHost, for testing.
 }
 
 // NewDNSHostProvider creates a new DNSHostProvider with the given options.

dnshostprovider_test.go

@@ -8,12 +8,20 @@ import (
 	"time"
 )
 
-func withLookupHost(lookupFn func(context.Context, string) ([]string, error)) DNSHostProviderOption {
-	return func(provider *DNSHostProvider) {
-		provider.lookupHost = lookupFn
+type lookupHostOption struct {
+	lookupFn lookupHostFn
+}
+
+func withLookupHost(lookupFn lookupHostFn) DNSHostProviderOption {
+	return lookupHostOption{
+		lookupFn: lookupFn,
 	}
 }
 
+func (o lookupHostOption) apply(provider *DNSHostProvider) {
+	provider.lookupHost = o.lookupFn
+}
+
 // TestDNSHostProviderCreate is just like TestCreate, but with an
 // overridden HostProvider that ignores the provided hostname.
 func TestIntegration_DNSHostProviderCreate(t *testing.T) {