Skip to content

Commit d6464ae

Browse files
authored
Merge pull request #5 from thockin/master
Get rid of InfoLogger, implement V() as additive
2 parents fd1f73b + fdff7dd commit d6464ae

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

example/main.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,13 @@ func (e E) Error() string {
3232
}
3333

3434
func main() {
35-
flag.Set("v", "3")
36-
flag.Set("alsologtostderr", "true")
35+
flag.Set("v", "1")
36+
flag.Set("logtostderr", "true")
3737
flag.Parse()
3838
log := glogr.New().WithName("MyName").WithValues("user", "you")
3939
log.Info("hello", "val1", 1, "val2", map[string]int{"k": 1})
40-
log.V(3).Info("nice to meet you")
40+
log.V(1).Info("you should see this")
41+
log.V(1).V(1).Info("you should NOT see this")
4142
log.Error(nil, "uh oh", "trouble", true, "reasons", []float64{0.1, 0.11, 3.14})
4243
log.Error(E{"an error occurred"}, "goodbye", "code", -1)
4344
glog.Flush()

glogr.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ func (l glogger) Error(err error, msg string, kvList ...interface{}) {
152152
glog.ErrorDepth(framesToCaller()+l.depth, l.prefix, " ", msgStr, " ", errStr, " ", fixedStr, " ", userStr)
153153
}
154154

155-
func (l glogger) V(level int) logr.InfoLogger {
155+
func (l glogger) V(level int) logr.Logger {
156156
new := l.clone()
157-
new.level = level
157+
new.level += level
158158
return new
159159
}
160160

@@ -177,4 +177,3 @@ func (l glogger) WithValues(kvList ...interface{}) logr.Logger {
177177
}
178178

179179
var _ logr.Logger = glogger{}
180-
var _ logr.InfoLogger = glogger{}

0 commit comments

Comments
 (0)