Skip to content

Commit 3da5426

Browse files
authored
Merge pull request #7 from thockin/with-call-depth
Add logr.Logger.WithCallDepth() support
2 parents e6c8687 + 3255373 commit 3da5426

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

example/main.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"flag"
2121

2222
"github.com/go-logr/glogr"
23+
"github.com/go-logr/logr"
2324
"github.com/golang/glog"
2425
)
2526

@@ -31,6 +32,14 @@ func (e E) Error() string {
3132
return e.str
3233
}
3334

35+
func Helper(log logr.Logger, msg string) {
36+
helper2(log, msg)
37+
}
38+
39+
func helper2(log logr.Logger, msg string) {
40+
logr.WithCallDepth(log, 2).Info(msg)
41+
}
42+
3443
func main() {
3544
flag.Set("v", "1")
3645
flag.Set("logtostderr", "true")
@@ -41,5 +50,6 @@ func main() {
4150
log.V(1).V(1).Info("you should NOT see this")
4251
log.Error(nil, "uh oh", "trouble", true, "reasons", []float64{0.1, 0.11, 3.14})
4352
log.Error(E{"an error occurred"}, "goodbye", "code", -1)
53+
Helper(log, "thru a helper")
4454
glog.Flush()
4555
}

glogr.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,4 +217,11 @@ func (l glogger) WithValues(kvList ...interface{}) logr.Logger {
217217
return new
218218
}
219219

220+
func (l glogger) WithCallDepth(depth int) logr.Logger {
221+
new := l.clone()
222+
new.depth += depth
223+
return new
224+
}
225+
220226
var _ logr.Logger = glogger{}
227+
var _ logr.CallDepthLogger = glogger{}

0 commit comments

Comments
 (0)