Skip to content

Commit 4bf4e55

Browse files
OctomergerOctomerger
authored
repo sync
2 parents 6786b20 + 3ea9735 commit 4bf4e55

File tree

11 files changed

+500
-1021
lines changed

11 files changed

+500
-1021
lines changed

‎.github/workflows/check-all-english-links.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Check all English links
22

33
on:
4+
workflow_dispatch:
45
schedule:
56
- cron: "40 19 * * *" # once a day at 19:40 UTC / 11:40 PST
67

@@ -10,21 +11,16 @@ jobs:
1011
if: github.repository == 'github/docs-internal'
1112
runs-on: ubuntu-latest
1213
steps:
13-
- uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
14-
- name: npm ci
15-
run: npm ci
16-
- name: npm run build
17-
run: npm run build
1814
- name: Run script
19-
run: script/check-external-links en > broken_links.md
15+
run: script/check-english-links.js > broken_links.md
2016
- name: Check if any broken links
2117
id: check
2218
run: |
23-
if [ "$(grep 'All links are good' broken_links.md)" ]; then
19+
if [ "$(grep '0 broken links found' broken_links.md)" ]; then
2420
echo ::set-output name=continue::no
2521
else
2622
echo "::set-output name=continue::yes"
27-
echo "::set-output name=title::$(grep 'found on help.github.com' broken_links.md)"
23+
echo "::set-output name=title::$(head -1 broken_links.md)"
2824
fi
2925
- if: ${{ steps.check.outputs.continue == 'yes' }}
3026
name: Create issue from file

‎.gitignore

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
node_modules
55
npm-debug.log
66
coverage
7-
8-
# blc: broken link checker
9-
blc_output.log
10-
blc_output_internal.log
11-
dist
7+
.linkinator
8+
broken_links.md
9+
dist

‎content/actions/index.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,19 @@ introLinks:
77
reference: /actions/reference
88
featuredLinks:
99
guides:
10-
- /actions/guides/setting-up-continuous-integration-using-workflow-templates
10+
- /actions/learn-github-actions
11+
- /actions/guides/about-continuous-integration
1112
- /actions/guides/about-packaging-with-github-actions
1213
gettingStarted:
1314
- /actions/managing-workflow-runs
1415
- /actions/hosting-your-own-runners
1516
popular:
1617
- /actions/reference/workflow-syntax-for-github-actions
1718
- /actions/reference/events-that-trigger-workflows
19+
- /actions/learn-github-actions
20+
- /actions/reference/context-and-expression-syntax-for-github-actions
21+
- /actions/reference/workflow-commands-for-github-actions
22+
- /actions/reference/environment-variables
1823
changelog:
1924
- title: Self-Hosted Runner Group Access Changes
2025
date: '2020-10-16'

‎layouts/product-landing.html

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,41 +28,51 @@ <h1 class="mb-3 font-mktg">{{ page.shortTitle }}</h1>
2828
<!-- Article links -->
2929
<div class="d-lg-flex gutter my-6 py-6">
3030
<div class="col-12 col-lg-4 mb-4 mb-lg-0">
31-
<div class="featured-links-heading pb-3 mb-4 border-bottom">
32-
<h3 class="f5 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.guides %}</h3>
31+
<div class="featured-links-heading mb-4 d-flex flex-items-baseline">
32+
<h3 class="f4 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.guides %}</h3>
33+
<a href="/{{ currentPath }}/guides" class="ml-4">View all {% octicon "arrow-right" height="14" class="v-align-middle" %}</a>
3334
</div>
3435
<ul class="list-style-none">
3536
{% for link in featuredLinks.guides %}
36-
<li class="Box px-3 py-1 mb-2">
37-
{% include featured-link %}
37+
<li class="border-top">
38+
<a class="link-with-intro Bump-link--hover no-underline d-block py-4" href="{{ link.href }}">
39+
<h4 class="link-with-intro-title link-gray-dark mb-1">{{ link.title }}<span class="Bump-link-symbol">→</span></h4>
40+
<p class="link-with-intro-intro color-gray-5 mb-0">{{ link.intro | truncatewords: 12 }}</p>
41+
</a>
3842
</li>
3943
{% endfor %}
4044
</ul>
4145
</div>
4246

4347
<div class="col-12 col-lg-4 mb-4 mb-lg-0">
44-
<div class="featured-links-heading pb-3 mb-4 border-bottom">
45-
<h3 class="f5 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.popular_articles %}</h3>
48+
<div class="featured-links-heading mb-4 d-flex flex-items-baseline">
49+
<h3 class="f4 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.popular_articles %}</h3>
4650
</div>
4751
<ul class="list-style-none">
4852
{% for link in featuredLinks.popular %}
49-
<li class="Box px-3 py-1 mb-2">
50-
{% include featured-link %}
53+
<li class="border-top">
54+
<a class="link-with-intro Bump-link--hover no-underline d-block py-3" href="{{ link.href }}">
55+
<h4 class="link-with-intro-title link-gray-dark">{{ link.title }}<span class="Bump-link-symbol">→</span></h4>
56+
</a>
5157
</li>
5258
{% endfor %}
5359
</ul>
5460
</div>
5561

5662
<div class="col-12 col-lg-4 mb-4 mb-lg-0">
57-
<div class="featured-links-heading pb-3 mb-4 border-bottom">
58-
<h3 class="f5 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.whats_new %}</h3>
63+
<div class="featured-links-heading mb-4 d-flex flex-items-baseline">
64+
<h3 class="f4 text-normal text-mono text-uppercase color-gray-5">{% data ui.toc.whats_new %}</h3>
65+
<a href="https://github.blog/changelog/" class="ml-4">View all {% octicon "arrow-right" height="14" class="v-align-middle" %}</a>
5966
</div>
6067
<ul class="list-style-none">
6168
{% for link in page.changelog %}
62-
<li class="mb-2">
63-
<a href="{{ link.href }}" class="Box text-gray-dark Bump-link--hover p-3 d-flex flex-justify-between flex-items-center no-underline">
69+
<li class="border-top">
70+
<a href="{{ link.href }}" class="d-block text-gray-dark Bump-link--hover py-3 no-underline">
71+
<time
72+
class="tooltipped tooltipped-n text-gray-light text-mono mb-1"
73+
aria-label="{{ link.date | date: '%B %d, %Y' }}"
74+
>{{ link.date | date: "%B %d" }}</time>
6475
<h4>{{ link.title }} <span class="Bump-link-symbol">→</span></h4>
65-
<span class="text-gray-light text-mono ml-2" style="white-space: nowrap">{{ link.date | date: "%B %d, %Y" }}</span>
6676
</a>
6777
</li>
6878
{% endfor %}

‎lib/excluded-links.js

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,20 @@
1+
// Linkinator treats the following as regex.
12
module.exports = [
2-
// GitHub search links fail with "429 Too Many Requests"
3-
'https://github.com/search?*',
3+
// Skip GitHub search links.
4+
'https://github.com/search?.*',
45
'https://github.com/github/gitignore/search?',
56

6-
// LinkedIn links fail due to bug: https://github.com/stevenvachon/broken-link-checker/issues/91
7-
'https://www.linkedin.com/*',
8-
9-
// blc returns "BLC_UNKNOWN" on this link, even though cURL returns "302 Found"
10-
'https://www.ilo.org/dyn/normlex/en/f?p=NORMLEXPUB:12100:0::NO::P12100_ILO_CODE:P029',
11-
12-
// the codercat link works but blc reports a false 404
13-
'https://github.com/Codertocat/hello-world-npm/packages/10696?version=1.0.1',
14-
15-
// this URL started returning 403 to blc and cURL even though it works in a browser; see docs-internal #10124
16-
'https://haveibeenpwned.com/',
17-
'https://haveibeenpwned.com/*',
18-
19-
// this is a private repo customers are given access to when they purchase Insights; see docs-internal #12037
7+
// These links require auth.
8+
'https://github.com/settings/profile',
9+
'https://github.com/github/docs/edit',
2010
'https://github.com/github/insights-releases/releases/latest',
2111

22-
// developer content uses these for examples; they should not be checked
23-
'http://localhost:1234/*',
12+
// Developer content uses these for examples; they should not be checked.
13+
'http://localhost:1234',
2414
'localhost:3000',
2515

26-
// this URL works but blc reports a false 404
16+
// Oneoff links that link checkers think are broken but are not.
17+
'https://haveibeenpwned.com/',
18+
'https://www.ilo.org/dyn/normlex/en/f?p=NORMLEXPUB:12100:0::NO::P12100_ILO_CODE:P029',
2719
'http://www.w3.org/wiki/LinkHeader/'
2820
]

0 commit comments

Comments
 (0)