Skip to content

Commit a0323b3

Browse files
committed
fix(styling): Dark Mode missing focus border styling
1 parent 054988f commit a0323b3

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

packages/common/src/styles/_variables.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,6 +1100,8 @@ $slick-dark-text-color: #d4d4d4 !default;
11001100
--slick-editor-modal-footer-border-top: var(--slick-base-dark-menu-border);
11011101
--slick-editor-modal-input-editor-border: var(--slick-base-dark-menu-border);
11021102
--slick-editor-modal-checkbox-editor-border: var(--slick-base-dark-menu-border);
1103+
--slick-editor-modal-large-editor-border: var(--slick-base-dark-menu-border);
1104+
--slick-editor-modal-select-editor-border: var(--slick-base-dark-menu-border);
11031105
--slick-editor-modal-container-box-shadow: 0 0 2px #606060;
11041106
--slick-editor-modal-reset-btn-bg-color: #383838;
11051107
--slick-editor-modal-close-btn-bg-color: transparent;

packages/common/src/styles/slick-editors.scss

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -399,10 +399,6 @@
399399
margin: var(--slick-editor-modal-input-editor-margin, v.$slick-editor-modal-input-editor-margin);
400400
border: var(--slick-editor-modal-input-editor-border, v.$slick-editor-modal-input-editor-border);
401401
padding: var(--slick-editor-modal-input-editor-padding, v.$slick-editor-modal-input-editor-padding);
402-
&:focus {
403-
border-color: var(--slick-text-editor-focus-border-color, v.$slick-text-editor-focus-border-color);
404-
box-shadow: var(--slick-text-editor-focus-box-shadow, v.$slick-text-editor-focus-box-shadow);
405-
}
406402
}
407403
.input-group {
408404
display: flex;
@@ -412,10 +408,6 @@
412408
border: var(--slick-editor-modal-large-editor-border, v.$slick-editor-modal-large-editor-border);
413409
border-radius: var(--slick-editor-modal-large-editor-border-radius, v.$slick-editor-modal-large-editor-border-radius);
414410
padding: var(--slick-editor-modal-large-editor-padding, v.$slick-editor-modal-large-editor-padding);
415-
&:focus-within {
416-
border-color: var(--slick-text-editor-focus-border-color, v.$slick-text-editor-focus-border-color);
417-
box-shadow: var(--slick-text-editor-focus-box-shadow, v.$slick-text-editor-focus-box-shadow);
418-
}
419411
textarea {
420412
width: 100%;
421413
height: 100%;
@@ -448,6 +440,15 @@
448440
}
449441
}
450442

443+
input:focus-within,
444+
.slick-large-editor-text:focus-within,
445+
.ms-parent-open button.ms-choice,
446+
button.ms-choice:focus-within {
447+
outline: 0;
448+
border-color: var(--slick-text-editor-focus-border-color, v.$slick-text-editor-focus-border-color);
449+
box-shadow: var(--slick-text-editor-focus-box-shadow, v.$slick-text-editor-focus-box-shadow);
450+
}
451+
451452
.autocomplete-container.input-group,
452453
.vanilla-picker.input-group {
453454
display: flex;

0 commit comments

Comments
 (0)