update trigger defaults

Author: suejung-sentry

src/sentry/models/repository.py

@@ -10,7 +10,7 @@
 from sentry.backup.dependencies import NormalizedModelName, get_model_name
 from sentry.backup.sanitize import SanitizableField, Sanitizer
 from sentry.backup.scopes import RelocationScope
-from sentry.constants import ObjectStatus
+from sentry.constants import DEFAULT_CODE_REVIEW_TRIGGERS, ObjectStatus
 from sentry.db.models import (
     BoundedBigIntegerField,
     BoundedPositiveIntegerField,
@@ -24,8 +24,8 @@
     rename_on_pending_deletion,
     reset_pending_deletion_field_names,
 )
-from sentry.models import OrganizationOption
-from sentry.models.repository_settings import RepositorySettings
+from sentry.models.options.organization_option import OrganizationOption
+from sentry.models.repositorysettings import RepositorySettings
 from sentry.organizations.services.organization.service import organization_service
 from sentry.signals import pending_delete
 from sentry.users.services.user import RpcUser
@@ -211,7 +211,7 @@ def handle_auto_enable_code_review(instance: Repository) -> None:
             default=[],
         )
         if not isinstance(triggers, list):
-            triggers = []
+            triggers = DEFAULT_CODE_REVIEW_TRIGGERS
 
         RepositorySettings.objects.get_or_create(
             repository_id=instance.id,

tests/sentry/models/test_repository.py

@@ -1,8 +1,9 @@
 from django.core import mail
 
-from sentry.models import OrganizationOption
+from sentry.constants import DEFAULT_CODE_REVIEW_TRIGGERS
+from sentry.models.options.organization_option import OrganizationOption
 from sentry.models.repository import Repository
-from sentry.models.repository_settings import RepositorySettings
+from sentry.models.repositorysettings import RepositorySettings
 from sentry.plugins.providers.dummy import DummyRepositoryProvider
 from sentry.testutils.cases import TestCase
 from sentry.testutils.helpers.features import with_feature
@@ -176,7 +177,7 @@ def test_invalid_triggers_type_defaults_to_empty_list(self):
         )
 
         settings = RepositorySettings.objects.get(repository=repo)
-        assert settings.code_review_triggers == []
+        assert settings.code_review_triggers == DEFAULT_CODE_REVIEW_TRIGGERS
 
     def test_settings_not_duplicated_on_update(self):
         """Updating a repository should not create duplicate settings."""