fix: Ensure tags values are strings #4459
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag value handling was updated to ensure compliance with the Sentry spec.
sentry_sdk/scope.py
,Scope.set_tag()
was modified to convert values usingsafe_str(value)
.Scope.set_tags()
was refactored to iterate and callself.set_tag()
for each item, ensuring consistent conversion.sentry_sdk/tracing.py
,Span.set_tag()
was updated to usesafe_str(value)
.Comprehensive tests were added:
tests/test_scope.py
, new tests coverScope.set_tag()
andScope.set_tags()
conversion and error handling.tests/tracing/test_span_tags.py
, was created to testSpan
andTransaction
tag conversion.tests/test_api.py
, tests were added for API-levelset_tag()
andset_tags()
.These changes ensure all tag values are strings, meeting Sentry spec requirements and improving compatibility with external tools like Sentry CLI.
Fixes #4391