Skip to content

Commit 95ecb8e

Browse files
AndrewChubatiukAndrii Chubatiuk
andauthored
fix for coverage (#6872)
Co-authored-by: Andrii Chubatiuk <[email protected]>
1 parent cb07071 commit 95ecb8e

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
branches:
1010
- master
1111
env:
12+
CYPRESS_COVERAGE: "true"
1213
NODE_VERSION: 18
1314
YARN_VERSION: 1.22.22
1415
REDASH_COOKIE_SECRET: "2H9gNG9obnAQ9qnR9BDTQUph6CbXKCzF"
@@ -75,6 +76,8 @@ jobs:
7576
docker cp tests:/app/junit.xml /tmp/test-results/unit-tests/results.xml
7677
- name: Upload coverage reports to Codecov
7778
uses: codecov/codecov-action@v4
79+
with:
80+
token: ${{ secrets.CODECOV_TOKEN }}
7881
- name: Store Test Results
7982
uses: actions/upload-artifact@v4
8083
with:
@@ -165,10 +168,6 @@ jobs:
165168
with:
166169
node-version: ${{ env.NODE_VERSION }}
167170
cache: 'yarn'
168-
- name: Enable Code Coverage Report For Master Branch
169-
if: endsWith(github.ref, '/master')
170-
run: |
171-
echo "CODE_COVERAGE=true" >> "$GITHUB_ENV"
172171
- name: Install Dependencies
173172
run: |
174173
npm install --global --force yarn@$YARN_VERSION

Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ COPY --chown=redash package.json yarn.lock .yarnrc /frontend/
2424
COPY --chown=redash viz-lib /frontend/viz-lib
2525
COPY --chown=redash scripts /frontend/scripts
2626

27-
# Controls whether to instrument code for coverage information
28-
ARG CODE_COVERAGE
29-
ENV BABEL_ENV=${CODE_COVERAGE:+test}
3027
RUN yarn --frozen-lockfile --network-concurrency 1;
3128
COPY --chown=redash client /frontend/client
3229
COPY --chown=redash webpack.config.js /frontend/

compose.base.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ services:
55
args:
66
FRONTEND_BUILD_MODE: ${FRONTEND_BUILD_MODE:-2}
77
INSTALL_GROUPS: ${INSTALL_GROUPS:-main,all_ds,dev}
8-
CODE_COVERAGE: ${CODE_COVERAGE:-"false"}
98
volumes:
109
- $PWD:${SERVER_MOUNT:-/app}
1110
command: manage version

compose.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,4 @@ services:
7878
COMMIT_INFO_REMOTE: ${COMMIT_INFO_REMOTE:-""}
7979
CYPRESS_PROJECT_ID: ${CYPRESS_PROJECT_ID:-""}
8080
CYPRESS_RECORD_KEY: ${CYPRESS_RECORD_KEY:-""}
81+
CYPRESS_COVERAGE: ${CYPRESS_COVERAGE:-""}

0 commit comments

Comments
 (0)