fix:formatlink missing last parm when empty and positional parms is in use

dmendez · dmendez · commit 565adbaec94b · 2025-01-10T11:44:31.000-03:00
diff --git a/common/src/main/java/com/genexus/URLRouter.java b/common/src/main/java/com/genexus/URLRouter.java
@@ -115,7 +115,7 @@ private static String convertParmsToQueryString(boolean useNamedParameters, Stri
 		for (int i = 0; i < parms.length; i++)
 		{
 			if (!useNamedParameters || parms.length != parmsName.length)
-				queryString = queryString + parms[i] + ((i < parms.length -1)? "," : "");
+				queryString = queryString + parms[i] + ((i < parms.length -1 || (i == parms.length -1 && parms[i].isEmpty()) ) ? "," : "");
 			else
 				queryString = queryString + parmsName[i] + "=" + parms[i] + ((i < parms.length -1)? "&" : "");
 		}

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ private static String convertParmsToQueryString(boolean useNamedParameters, Stri`
`115`	`115`	`for (int i = 0; i < parms.length; i++)`
`116`	`116`	`{`
`117`	`117`	`if (!useNamedParameters \|\| parms.length != parmsName.length)`
`118`		`- queryString = queryString + parms[i] + ((i < parms.length -1)? "," : "");`
	`118`	`+ queryString = queryString + parms[i] + ((i < parms.length -1 \|\| (i == parms.length -1 && parms[i].isEmpty()) ) ? "," : "");`
`119`	`119`	`else`
`120`	`120`	`queryString = queryString + parmsName[i] + "=" + parms[i] + ((i < parms.length -1)? "&" : "");`
`121`	`121`	`}`