fix: install phpactor on first launch (#42)

Author: gbprod

README.md

@@ -61,15 +61,15 @@ Install the plugin with your preferred package manager:
 {
   {
     "gbprod/phpactor.nvim",
-    build = function()
-      require("phpactor.handler.update")()
-    end,
+    ft = "php",
     dependencies = {
       "nvim-lua/plenary.nvim",
-      "neovim/nvim-lspconfig"
+      "neovim/nvim-lspconfig",
+      -- If the update/install notification doesn't show properly,
+      -- you should also add here UI plugins like "folke/noice.nvim" or "stevearc/dressing.nvim"
     },
     opts = {
-      -- you're options coes here
+      -- you're options goes here
     },
   },
 }
@@ -139,8 +139,14 @@ Git binary.
 Default: `none`  
 Accepted values: `none|daily|always`
 
-This will check if phpactor install is up-to-date on nvim startup. This could be
-slow, use wisely.
+This will check if phpactor install is up-to-date when the plugin is loaded.  
+This could be slow, use wisely.
+
+### install.confirm
+
+Default: `true`
+
+If true, will ask for confirmation before installing/updating phpactor.
 
 ### `lspconfig.enabled`
 

lua/phpactor.lua

@@ -31,10 +31,7 @@ phpactor.AVAILABLE_RPC = {
 function phpactor.setup(options)
   config.setup(options)
 
-  vim.api.nvim_create_autocmd("VimEnter", {
-    pattern = "*",
-    callback = phpactor.check_install,
-  })
+  vim.schedule(phpactor.check_install)
 
   if config.options.lspconfig.enabled then
     require("lspconfig").phpactor.setup(vim.tbl_deep_extend("force", {
@@ -47,6 +44,26 @@ function phpactor.setup(options)
 end
 
 function phpactor.check_install()
+  local do_update = function(confirm_message)
+    if config.options.install.confirm then
+      vim.ui.select({ "Yes", "No" }, {
+        prompt = confirm_message,
+      }, function(item)
+        if item == "Yes" then
+          require("phpactor.handler.update")()
+        end
+      end)
+    else
+      require("phpactor.handler.update")()
+    end
+  end
+
+  if not require("phpactor.check_installed")() then
+    do_update("Phpactor is not installed, would you like to install it?")
+
+    return
+  end
+
   if config.options.install.check_on_startup == "none" then
     return
   end
@@ -59,8 +76,8 @@ function phpactor.check_install()
     vim.g.PHPACTOR_LAST_CHECK = os.date("%x")
   end
 
-  if not require("phpactor.check_install")() then
-    vim.notify("PhpActor is outdated\nrun `:PhpActor update`", vim.log.levels.INFO, { title = "PhpActor" })
+  if not require("phpactor.check_uptodate")() then
+    do_update("Phpactor is not up-to-date, would you like to update it?")
   end
 end
 

lua/phpactor/check_installed.lua

@@ -0,0 +1,8 @@
+local config = require("phpactor.config")
+local Path = require("plenary.path")
+
+return function()
+  local phpactor_bin_path = Path:new(config.options.install.bin)
+
+  return phpactor_bin_path:exists()
+end

lua/phpactor/check_install.lua renamed to lua/phpactor/check_uptodate.lua

@@ -4,6 +4,10 @@ local Path = require("plenary.path")
 return function()
   local phpactor_path = Path:new(config.options.install.path .. "phpactor/")
 
+  if not phpactor_path:exists() then
+    return false
+  end
+
   vim.fn.system({
     config.options.install.git_bin,
     "-C",

lua/phpactor/config.lua

@@ -11,6 +11,7 @@ local default_values = {
     composer_bin = "composer",
     git_bin = "git",
     check_on_startup = "none",
+    confirm = true,
   },
   lspconfig = {
     enabled = true,

lua/phpactor/handler/update.lua

@@ -32,7 +32,7 @@ return function()
       return
     end
   else
-    if require("phpactor.check_install")() then
+    if require("phpactor.check_uptodate")() then
       vim.notify("PhpActor is already up-to-date", vim.log.levels.INFO, { title = "PhpActor" })
 
       return

spec/init.lua

@@ -30,7 +30,11 @@ function M.setup()
   M.load("nvim-lua/plenary.nvim")
   M.load("neovim/nvim-lspconfig")
 
-  require("phpactor").setup()
+  require("phpactor").setup({
+    install = {
+      confirm = false,
+    },
+  })
 end
 
 M.setup()