Lock before assigning the server.listener to prevent data race

mostafa · mostafa · commit a7769850c1fd · 2023-10-24T20:40:58.000+02:00
diff --git a/network/server.go b/network/server.go
@@ -415,7 +415,9 @@ func (s *Server) Run() *gerr.GatewayDError {
 		s.logger.Error().Err(origErr).Msg("Server failed to start listening")
 		return gerr.ErrServerListenFailed.Wrap(origErr)
 	}
+	s.mu.Lock()
 	s.engine.listener = listener
+	s.mu.Unlock()
 	defer s.engine.listener.Close()
 
 	if s.engine.listener == nil {

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,9 @@ func (s Server) Run() gerr.GatewayDError {`
`415`	`415`	`s.logger.Error().Err(origErr).Msg("Server failed to start listening")`
`416`	`416`	`return gerr.ErrServerListenFailed.Wrap(origErr)`
`417`	`417`	`}`
	`418`	`+ s.mu.Lock()`
`418`	`419`	`s.engine.listener = listener`
	`420`	`+ s.mu.Unlock()`
`419`	`421`	`defer s.engine.listener.Close()`
`420`	`422`
`421`	`423`	`if s.engine.listener == nil {`