Skip to content

Commit b36b70f

Browse files
remove exe from testdata (#561)
After considering #550 and #551, there seems it's hard to create a windows executable that satisfies these 2 conditions: - is small in size - does not trigger antivirus alerts; seems like many antiviruses just don't care what's inside an exe. If it's .exe then it's a virus. Looking back on it, adding fixture files is not perfect: seems nice to have the library tests work with real files, but: - it does not count towards test-coverage - real files increase repo size Going forward I think I will remove more and more of the files in testdata folder, and add more unit tests.
1 parent e802551 commit b36b70f

File tree

2 files changed

+0
-1
lines changed

2 files changed

+0
-1
lines changed

mimetype_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ var files = map[string]string{
5959
"dwg.dwg": "image/vnd.dwg",
6060
"eot.eot": "application/vnd.ms-fontobject",
6161
"epub.epub": "application/epub+zip",
62-
"exe.exe": "application/vnd.microsoft.portable-executable",
6362
"fdf.fdf": "application/vnd.fdf",
6463
"fits.fits": "application/fits",
6564
"flac.flac": "audio/flac",

testdata/exe.exe

-1.96 MB
Binary file not shown.

0 commit comments

Comments
 (0)