Commit b36b70f
authored
remove exe from testdata (#561)
After considering #550 and #551, there seems it's hard to create a
windows executable that satisfies these 2 conditions:
- is small in size
- does not trigger antivirus alerts; seems like many antiviruses just
don't care what's inside an exe. If it's .exe then it's a virus.
Looking back on it, adding fixture files is not perfect: seems nice to
have the library tests work with real files, but:
- it does not count towards test-coverage
- real files increase repo size
Going forward I think I will remove more and more of the files in
testdata folder, and add more unit tests.1 parent e802551 commit b36b70f
2 files changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
| |||
Binary file not shown.
0 commit comments