From 9bb50c36317e7a1e545aee56a2dd81235dae5016 Mon Sep 17 00:00:00 2001 From: David Mamanakis Date: Tue, 30 Jan 2024 10:05:06 -0700 Subject: [PATCH 1/3] Update qa.js QA used WDIO and some of the ways WDIO is formatted, we use unnamed functions as our "it" functions (etc) ... We CAN use arrow functions, but that kills the ability to use "this" in our tests. Which we use. --- qa.js | 1 + 1 file changed, 1 insertion(+) diff --git a/qa.js b/qa.js index c8f0ba1..de4bdc4 100644 --- a/qa.js +++ b/qa.js @@ -19,6 +19,7 @@ module.exports = { 'testing-library/no-await-sync-query': 'off', // All @testing-library/webdriverio queries are async (https://testing-library.com/docs/webdriverio-testing-library/intro/) 'testing-library/prefer-screen-queries': 'off', // We use browser instead of screen for @testing-library/webdriverio '@babel/no-unused-expressions': 'off' // to allow expressions like this: tree.expect(await (await $(tree.MBTpageObjects.getBCButton())).isDisplayed()).to.be.true + 'func-names': 'off' // to allow for how WDIO does "it" functions: "it('Login', async function () {". We need "this" and we can keep "this" by using "unnamed async function" } } ] From 0dbc9f32e1b49fbcf405bb16f30aadb54c3972f2 Mon Sep 17 00:00:00 2001 From: David Mamanakis Date: Tue, 30 Jan 2024 10:14:37 -0700 Subject: [PATCH 2/3] Update qa.js --- qa.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa.js b/qa.js index de4bdc4..24c6d55 100644 --- a/qa.js +++ b/qa.js @@ -18,7 +18,7 @@ module.exports = { 'import/no-extraneous-dependencies': ['error', { 'devDependencies': true }], 'testing-library/no-await-sync-query': 'off', // All @testing-library/webdriverio queries are async (https://testing-library.com/docs/webdriverio-testing-library/intro/) 'testing-library/prefer-screen-queries': 'off', // We use browser instead of screen for @testing-library/webdriverio - '@babel/no-unused-expressions': 'off' // to allow expressions like this: tree.expect(await (await $(tree.MBTpageObjects.getBCButton())).isDisplayed()).to.be.true + '@babel/no-unused-expressions': 'off', // to allow expressions like this: tree.expect(await (await $(tree.MBTpageObjects.getBCButton())).isDisplayed()).to.be.true 'func-names': 'off' // to allow for how WDIO does "it" functions: "it('Login', async function () {". We need "this" and we can keep "this" by using "unnamed async function" } } From e17e2546254796224b68e22745be1b694fb0ed6b Mon Sep 17 00:00:00 2001 From: David Mamanakis Date: Tue, 30 Jan 2024 10:27:15 -0700 Subject: [PATCH 3/3] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 040c495..a88fcd1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@fs/eslint-config-tree", - "version": "6.0.0", + "version": "6.0.1", "description": "Shared Tree configuration that contains overrides and enhancements on top of the base frontier configuration.", "main": "index.js", "repository": {