Skip to content

Commit 8bca9c9

Browse files
committed
don't warn on undefined
1 parent 2bf75f0 commit 8bca9c9

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

demo/test/snapshots/lint-output.js.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,7 +1911,7 @@ Generated by [AVA](https://ava.li).
19111911
"error"␊
19121912
],␊
19131913
"no-undefined": [␊
1914-
"warn"␊
1914+
"off"␊
19151915
],␊
19161916
"no-underscore-dangle": [␊
19171917
"error",␊
@@ -3644,8 +3644,6 @@ Generated by [AVA](https://ava.li).
36443644
39:18 error Unnecessary use of boolean literals in conditional expression no-unneeded-ternary␊
36453645
39:18 warning Unexpected constant condition no-constant-condition␊
36463646
42:7 warning Correct one of the identical sub-expressions on both sides of operator "&&" sonarjs/no-identical-expressions␊
3647-
42:18 warning Unexpected use of undefined no-undefined␊
3648-
42:42 warning Unexpected use of undefined no-undefined␊
36493647
42:55 error 'params' is not defined no-undef␊
36503648
43:5 warning This function expects 1 argument, but 2 were provided sonarjs/no-extra-arguments␊
36513649
44:30 error Module path/to/legacyModule is deprecated. Use module x instead deprecate/import␊
@@ -3701,6 +3699,6 @@ Generated by [AVA](https://ava.li).
37013699
18:96 warning Delete `;` prettier/prettier␊
37023700
20:2 warning Delete `;` prettier/prettier␊
37033701
3704-
79 problems (35 errors, 44 warnings)␊
3702+
77 problems (35 errors, 42 warnings)␊
37053703
4 errors and 6 warnings potentially fixable with the `--fix` option.␊
37063704
`
-19 Bytes
Binary file not shown.

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ module.exports = {
2020
'no-case-declarations': 'off', // frontier has this as error
2121
'no-else-return': 'off', // frontier has this as error
2222
'no-prototype-builtins': 'warn', // frontier has this as error
23-
'no-undefined': 'warn', // frontier has this as error
2423
'prefer-const': 'warn', // frontier has this as error
2524

2625
'no-warning-comments': [
@@ -32,6 +31,7 @@ module.exports = {
3231
'no-shadow': 'warn', // frontier has this as error, tw-blue has this as off
3332

3433
'valid-jsdoc': ['warn'], // frontier has this as off
34+
'no-undefined': 'off', // frontier has this as off, we had this as warn. I think it really should be off which means removing this line.
3535

3636
'jsdoc/check-access': 'off',
3737
'jsdoc/check-alignment': 'warn',

0 commit comments

Comments
 (0)