Skip to content

Commit a6b1f88

Browse files
committed
Fix unzip and add more unit tests. #16
1 parent f9932dd commit a6b1f88

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

datapackage/package.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,6 @@ func Load(path string, loaders ...validator.RegistryLoader) (*Package, error) {
301301
if err != nil {
302302
return nil, err
303303
}
304-
defer os.RemoveAll(dir)
305304
fNames, err := unzip(path, dir)
306305
if err != nil {
307306
return nil, err

datapackage/package_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ func TestLoad(t *testing.T) {
494494
// Writing a file which is in a subdir.
495495
f1, err := w.Create("data/foo.csv")
496496
is.NoErr(err)
497-
_, err = f1.Write([]byte(`foo\nbar`))
497+
_, err = f1.Write([]byte(`foo`))
498498
is.NoErr(err)
499499
is.NoErr(w.Close())
500500

@@ -504,6 +504,9 @@ func TestLoad(t *testing.T) {
504504
res := pkg.GetResource("res1")
505505
is.Equal(res.name, "res1")
506506
is.Equal(res.path, []string{"data/foo.csv"})
507+
contents, err := res.ReadAll()
508+
is.NoErr(err)
509+
is.Equal(contents[0], []string{"foo"})
507510
})
508511
t.Run("Remote", func(t *testing.T) {
509512
is := is.New(t)

0 commit comments

Comments
 (0)