in_forward: Check return values from mutex functions

Signed-off-by: Hiroshi Hatake <[email protected]>

Author: cosmo0920

plugins/in_forward/fw.c

@@ -358,7 +358,9 @@ static int in_fw_init(struct flb_input_instance *ins,
 
 static void in_fw_pause(void *data, struct flb_config *config)
 {
+    int ret;
     struct flb_in_fw_config *ctx = data;
+
     if (config->is_running == FLB_TRUE) {
         /*
          * This is the case when we are not in a shutdown phase, but
@@ -367,11 +369,20 @@ static void in_fw_pause(void *data, struct flb_config *config)
          * and wait for the ingestion to resume.
          */
         flb_input_collector_pause(ctx->coll_fd, ctx->ins);
-        if (pthread_mutex_lock(&ctx->conn_mutex)) {
-            fw_conn_del_all(ctx);
-            ctx->is_paused = FLB_TRUE;
+
+        ret = pthread_mutex_lock(&ctx->conn_mutex);
+        if (ret != 0) {
+            flb_plg_error(ctx->ins, "cannot lock collector mutex");
+            return;
+        }
+
+        fw_conn_del_all(ctx);
+        ctx->is_paused = FLB_TRUE;
+        ret = pthread_mutex_unlock(&ctx->conn_mutex);
+        if (ret != 0) {
+            flb_plg_error(ctx->ins, "cannot unlock collector mutex");
+            return;
         }
-        pthread_mutex_unlock(&ctx->conn_mutex);
     }
 
     /*
@@ -388,13 +399,24 @@ static void in_fw_pause(void *data, struct flb_config *config)
 }
 
 static void in_fw_resume(void *data, struct flb_config *config) {
+    int ret;
     struct flb_in_fw_config *ctx = data;
+
     if (config->is_running == FLB_TRUE) {
         flb_input_collector_resume(ctx->coll_fd, ctx->ins);
-        if (pthread_mutex_lock(&ctx->conn_mutex)) {
-            ctx->is_paused = FLB_FALSE;
+
+        ret = pthread_mutex_lock(&ctx->conn_mutex);
+        if (ret != 0) {
+            flb_plg_error(ctx->ins, "cannot lock collector mutex");
+            return;
+        }
+
+        ctx->is_paused = FLB_FALSE;
+        ret = pthread_mutex_unlock(&ctx->conn_mutex);
+        if (ret != 0) {
+            flb_plg_error(ctx->ins, "cannot unlock collector mutex");
+            return;
         }
-        pthread_mutex_unlock(&ctx->conn_mutex);
     }
 }