Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 27, 2024

Bumps esbuild from 0.21.3 to 0.21.4.

Release notes

Sourced from esbuild's releases.

v0.21.4

  • Update support for import assertions and import attributes in node (#3778)

    Import assertions (the assert keyword) have been removed from node starting in v22.0.0. So esbuild will now strip them and generate a warning with --target=node22 or above:

    ▲ [WARNING] The "assert" keyword is not supported in the configured target environment ("node22") [assert-to-with]
    
    example.mjs:1:40:
      1 │ import json from "esbuild/package.json" assert { type: "json" }
        │                                         ~~~~~~
        ╵                                         with
    

    Did you mean to use "with" instead of "assert"?

    Import attributes (the with keyword) have been backported to node 18 starting in v18.20.0. So esbuild will no longer strip them with --target=node18.N if N is 20 or greater.

  • Fix for await transform when a label is present

    This release fixes a bug where the for await transform, which wraps the loop in a try statement, previously failed to also move the loop's label into the try statement. This bug only affects code that uses both of these features in combination. Here's an example of some affected code:

    // Original code
    async function test() {
      outer: for await (const x of [Promise.resolve([0, 1])]) {
        for (const y of x) if (y) break outer
        throw 'fail'
      }
    }
    // Old output (with --target=es6)
    function test() {
    return __async(this, null, function* () {
    outer: try {
    for (var iter = __forAwait([Promise.resolve([0, 1])]), more, temp, error; more = !(temp = yield iter.next()).done; more = false) {
    const x = temp.value;
    for (const y of x) if (y) break outer;
    throw "fail";
    }
    } catch (temp) {
    error = [temp];
    } finally {
    try {
    more && (temp = iter.return) && (yield temp.call(iter));
    } finally {
    if (error)
    throw error[0];
    }
    }

... (truncated)

Changelog

Sourced from esbuild's changelog.

0.21.4

  • Update support for import assertions and import attributes in node (#3778)

    Import assertions (the assert keyword) have been removed from node starting in v22.0.0. So esbuild will now strip them and generate a warning with --target=node22 or above:

    ▲ [WARNING] The "assert" keyword is not supported in the configured target environment ("node22") [assert-to-with]
    
    example.mjs:1:40:
      1 │ import json from "esbuild/package.json" assert { type: "json" }
        │                                         ~~~~~~
        ╵                                         with
    

    Did you mean to use "with" instead of "assert"?

    Import attributes (the with keyword) have been backported to node 18 starting in v18.20.0. So esbuild will no longer strip them with --target=node18.N if N is 20 or greater.

  • Fix for await transform when a label is present

    This release fixes a bug where the for await transform, which wraps the loop in a try statement, previously failed to also move the loop's label into the try statement. This bug only affects code that uses both of these features in combination. Here's an example of some affected code:

    // Original code
    async function test() {
      outer: for await (const x of [Promise.resolve([0, 1])]) {
        for (const y of x) if (y) break outer
        throw 'fail'
      }
    }
    // Old output (with --target=es6)
    function test() {
    return __async(this, null, function* () {
    outer: try {
    for (var iter = __forAwait([Promise.resolve([0, 1])]), more, temp, error; more = !(temp = yield iter.next()).done; more = false) {
    const x = temp.value;
    for (const y of x) if (y) break outer;
    throw "fail";
    }
    } catch (temp) {
    error = [temp];
    } finally {
    try {
    more && (temp = iter.return) && (yield temp.call(iter));
    } finally {
    if (error)
    throw error[0];
    }

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added scope:dependencies dependency updates type:build changes to the build system or external dependencies labels May 27, 2024
@flex-development flex-development bot enabled auto-merge (squash) May 27, 2024 02:09
@codecov
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8efbf6a) to head (2f4af3b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           33        33           
  Branches         7         7           
=========================================
  Hits            33        33           
Flag Coverage Δ
node18 100.00% <ø> (ø)
node19 100.00% <ø> (ø)
node20 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec67911...2f4af3b. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/esbuild-0.21.4 branch from d721c7c to b05c830 Compare May 27, 2024 02:12
Copy link
Contributor

@flex-development flex-development bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.21.3 to 0.21.4.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.21.3...v0.21.4)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/esbuild-0.21.4 branch from b05c830 to 2f4af3b Compare May 27, 2024 02:16
Copy link
Contributor

@flex-development flex-development bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@flex-development flex-development bot merged commit 5d0a78a into main May 27, 2024
@flex-development flex-development bot deleted the dependabot/npm_and_yarn/esbuild-0.21.4 branch May 27, 2024 02:20
@flex-development
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent
activity after it was closed. Please open a new issue for related bugs or features. Be
sure to reference this issue.

@flex-development flex-development bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope:dependencies dependency updates type:build changes to the build system or external dependencies

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant