fix: disable content scripts

Author: eungyeole

biome.json

@@ -1,22 +1,24 @@
 {
-	"$schema": "https://biomejs.dev/schemas/1.6.1/schema.json",
-	"organizeImports": {
-	  "enabled": true
-	},
-	"formatter": {
-	  "indentStyle": "space",
-	  "indentWidth": 2
-	},
-	"javascript": {
-	  "formatter": {
-		"trailingComma": "es5"
-	  }
-	},
-	"linter": {
-	  "enabled": true,
-	  "rules": {
-		"recommended": true
-	  }
-	}
+  "$schema": "https://biomejs.dev/schemas/1.6.1/schema.json",
+  "organizeImports": {
+    "enabled": true
+  },
+  "formatter": {
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "javascript": {
+    "formatter": {
+      "trailingComma": "es5"
+    }
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "files": {
+    "ignore": ["dist"]
   }
-  
+}

packages/rsbuild-plugin-web-extension/package.json

@@ -10,8 +10,7 @@
     ".": {
       "types": "./dist/index.d.ts",
       "import": "./dist/index.js",
-      "require": "./dist/index.cjs",
-      "default": "./dist/index.js"
+      "require": "./dist/index.cjs"
     }
   },
   "files": ["dist"],

packages/rsbuild-plugin-web-extension/src/index.ts

@@ -1,4 +1,4 @@
-import { type RsbuildPlugin } from "@rsbuild/core";
+import type { RsbuildPlugin } from "@rsbuild/core";
 import { makeManifest } from "./manifest/make-manifest.js";
 
 interface Options {
@@ -19,46 +19,10 @@ export const pluginWebExtension = ({ manifest }: Options): RsbuildPlugin => ({
      * @issue https://github.com/web-infra-dev/rspack/issues/5971
      * @ref https://github.com/webdiscus/html-bundler-webpack-plugin
      */
-    const entry = htmlEntryPoints.reduce(
-      (acc, [name, entry]) => ({
-        ...acc,
-        [name]: entry?.replace(/\.html$/, ".tsx"),
-      }),
-      {}
-    );
-
-    const contentScripts = manifest.content_scripts?.map((script) => {
-      if (!script.js) {
-        return;
-      }
-      if (script.js.length > 1) {
-        throw new Error(
-          `Multiple scripts are not supported for content_scripts not yet: ${script.js}` // TODO: support multiple scripts
-        );
-      }
-      if (!/index\.(js|ts|tsx)$/.test(script.js[0].split("/").pop()!)) {
-        throw new Error(
-          `Support only index.(js|ts|tsx) is supported for content_scripts yet: ${script.js}` // TODO: support file name to entry name
-        );
-      }
-
-      const entryName = script.js[0]
-        .split("/")
-        .pop()!
-        .replace(/\.(js|ts|tsx)$/, "");
-
-      return {
-        [entryName]: script.js[0],
-      };
-    });
-
-    const contentScriptsEntry = contentScripts?.reduce(
-      (acc, scripts) => ({
-        ...acc,
-        ...scripts,
-      }),
-      {}
-    );
+    const entry = htmlEntryPoints.reduce((acc, [name, entry]) => {
+      acc[name] = entry?.replace(/\.html$/, ".tsx");
+      return acc;
+    }, {} as Record<string, string | undefined>);
 
     api.modifyRspackConfig((config, { mergeConfig, HtmlPlugin }) => {
       return mergeConfig(config, {
@@ -80,7 +44,6 @@ export const pluginWebExtension = ({ manifest }: Options): RsbuildPlugin => ({
         source: {
           entry: {
             ...entry,
-            ...contentScriptsEntry,
             background: manifest.background?.service_worker || "",
           },
         },

packages/rsbuild-plugin-web-extension/src/manifest/make-manifest.ts

@@ -18,5 +18,5 @@ export const makeManifest = async (
     ManifestParser.convertManifestToString(manifest.default)
   );
 
-  logger.log(`Manifest file created`);
+  logger.log("Manifest file created");
 };

packages/rsbuild-plugin-web-extension/src/manifest/parser.ts

@@ -9,9 +9,10 @@ const getOutputFile = (file: string): string => {
 class ManifestParser {
   private constructor() {}
 
-  static convertManifestToString(manifest: Manifest): string {
+  static convertManifestToString(_manifest: Manifest): string {
+    let manifest = { ..._manifest };
     if (process.env.__FIREFOX__) {
-      manifest = this.convertToFirefoxCompatibleManifest(manifest);
+      manifest = ManifestParser.convertToFirefoxCompatibleManifest(manifest);
     }
 
     return getOutputFile(JSON.stringify(manifest, null, 2));
@@ -34,7 +35,9 @@ class ManifestParser {
     manifestCopy.content_security_policy = {
       extension_pages: "script-src 'self'; object-src 'self'",
     };
-    delete manifestCopy.options_page;
+
+    manifestCopy.options_page = undefined;
+
     return manifestCopy as Manifest;
   }
 }