Replies: 1 comment
-
Hi, yes I would accept a PR to v4, but please also write documentation for it. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @danharrin,
I’d like to propose a small enhancement to the
dropdownOffset()
method on theHasDropdown
trait.Current behavior:
It only accepts a single integer or closure for the offset.
Proposed change:
Allow passing two parameters —
mainAxis
andcrossAxis
— like this:This would enable better control over dropdown positioning using Floating UI’s [offset middleware](https://floating-ui.com/docs/offset), which accepts an object with
mainAxis
andcrossAxis
properties.Importantly, this change would not break existing usage since passing a single parameter would keep the current behavior intact.
Examples:
Would this be a suitable addition to Filament? If so, I can prepare a PR.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions