feat(popup): linkify all urls in video descriptions

Author: fent

background/sources/collections/haloruns.js

@@ -5,8 +5,9 @@ const RECORDS_PAGE = 'https://haloruns.com/records?recent';
 const resolveLink = ($link) => {
   return new URL($link.getAttribute('href'), RECORDS_PAGE).href;
 };
+
+const $a = document.createElement('a');
 const embedLink = ($link) => {
-  const $a = document.createElement('a');
   $a.href = resolveLink($link);
   $a.target = '_blank';
   $a.textContent = $link.textContent;

background/sources/index.js

@@ -45,20 +45,26 @@ const sources = {
           let videos;
           try {
             videos = await fn();
+            for (let video of videos) {
+              // Add links to video description.
+              if (video.desc) {
+                video.desc = util.embedLinks(video.desc);
+              }
+            }
+            if (!isHost) {
+              videos = await util.parallelFilter(videos, sources.addMetaToVideo);
+            }
             cachedResults[type][source] = videos;
+
           } catch (err) {
             console.warn(`Failed to get videos for ${source}: ${err.message}`);
             console.error(err);
 
             // Fallback to cached videos from this source if getting videos fails.
             videos = cachedResults[type][source] || [];
           }
-          if (isHost) {
-            return { source, videos };
-          } else {
-            videos = await util.parallelFilter(videos, sources.addMetaToVideo);
-            return { source, videos };
-          }
+
+          return { source, videos };
         }));
     };
 
@@ -165,6 +171,7 @@ const sources = {
         video[field] = meta[field];
       }
     });
+
     return true;
   },
 

background/util.js

@@ -261,3 +261,20 @@ export const uniq = (arr) => {
 export const sleep = (ms) => {
   return new Promise(resolve => setTimeout(resolve, ms));
 };
+
+/**
+ * Converts urls in a string, that are not already html links, to html links.
+ *
+ * @param {string} str
+ * @return {string}
+ */
+const $a = document.createElement('a');
+export const embedLinks = (str) => {
+  return str.replace(/(href=")?(https?:\/\/[^"'()[\]{} ]+)/g, (m, p1, url) => {
+    if (p1) return m;
+    $a.href = url;
+    $a.target = '_blank';
+    $a.textContent = url;
+    return $a.outerHTML;
+  });
+};