Skip to content

Commit 93e6cd4

Browse files
authored
Merge pull request #621 from fede1024/scanterog/update-kafka-for-integration-tests
Add support for kafka 3.5 in integration tests
2 parents be26f99 + 67d91e6 commit 93e6cd4

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ jobs:
6969
fail-fast: false
7070
matrix:
7171
include:
72+
- confluent-version: 7.5.1
73+
kafka-version: 3.5
7274
- confluent-version: 5.3.1
7375
kafka-version: 2.3
7476
- confluent-version: 5.0.3

docker-compose.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: '3'
22

33
services:
44
kafka:
5-
image: confluentinc/cp-kafka:${CONFLUENT_VERSION:-5.3.1}
5+
image: confluentinc/cp-kafka:${CONFLUENT_VERSION:-7.5.1}
66
environment:
77
- KAFKA_BROKER_ID=0
88
- KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
@@ -16,7 +16,7 @@ services:
1616
links: [zookeeper]
1717

1818
zookeeper:
19-
image: confluentinc/cp-zookeeper:${CONFLUENT_VERSION:-5.3.1}
19+
image: confluentinc/cp-zookeeper:${CONFLUENT_VERSION:-7.5.1}
2020
environment:
2121
- ZOOKEEPER_CLIENT_PORT=2181
2222
ports: ["2181:2181"]

tests/test_admin.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,14 @@ async fn test_topics() {
174174
is_default: false,
175175
is_sensitive: false,
176176
};
177+
let default_max_msg_bytes = if get_broker_version() <= KafkaVersion(2, 3, 0, 0) {
178+
"1000012"
179+
} else {
180+
"1048588"
181+
};
177182
let expected_entry2 = ConfigEntry {
178183
name: "max.message.bytes".into(),
179-
value: Some("1000012".into()),
184+
value: Some(default_max_msg_bytes.into()),
180185
source: ConfigSource::Default,
181186
is_read_only: false,
182187
is_default: true,

0 commit comments

Comments
 (0)