Skip to content

Commit ffa33ad

Browse files
hermesdtAlvaro Duran Tovar
andauthored
feat: Allow to pass secrets and environment variables to transformation service (#2632)
Signed-off-by: Alvaro Duran Tovar <[email protected]> Co-authored-by: Alvaro Duran Tovar <[email protected]>
1 parent 1e02066 commit ffa33ad

File tree

3 files changed

+31
-3
lines changed

3 files changed

+31
-3
lines changed

infra/charts/feast/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v1
22
description: Feature store for machine learning
33
name: feast
4-
version: 0.20.0
4+
version: 0.20.1
55
keywords:
66
- machine learning
77
- big data

infra/charts/feast/charts/transformation-service/templates/deployment.yaml

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,44 @@ spec:
3030
nodeSelector:
3131
{{- toYaml . | nindent 8 }}
3232
{{- end }}
33+
34+
volumes:
35+
{{- range $secret := .Values.secrets }}
36+
- name: {{ $secret }}
37+
secret:
38+
secretName: {{ $secret }}
39+
{{- end }}
40+
3341
containers:
3442
- name: {{ .Chart.Name }}
3543
image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
3644
imagePullPolicy: {{ .Values.image.pullPolicy }}
3745
ports:
3846
- name: grpc
3947
containerPort: {{ .Values.service.grpc.targetPort }}
40-
48+
49+
volumeMounts:
50+
{{- range $secret := .Values.secrets }}
51+
- name: {{ $secret }}
52+
mountPath: "/etc/secrets/{{ $secret }}"
53+
readOnly: true
54+
{{- end }}
55+
4156
env:
4257
- name: FEATURE_TRANSFORMATION_SERVER_PORT
4358
value: {{ .Values.service.grpc.targetPort | quote }}
4459
- name: FEATURE_STORE_YAML_BASE64
4560
value: {{ tpl (.Files.Get "config/feature_store.yaml") . | b64enc | quote }}
46-
61+
62+
{{- range $key, $value := .Values.envOverrides }}
63+
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
64+
{{- if eq (kindOf $value) "map" }}
65+
valueFrom:
66+
{{- toYaml $value | nindent 12 }}
67+
{{- else }}
68+
value: {{ $value | quote }}
69+
{{- end }}
70+
{{- end }}
71+
4772
resources:
4873
{{- toYaml .Values.resources | nindent 10 }}

infra/charts/feast/charts/transformation-service/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,8 @@ nodeSelector: {}
3030
# envOverrides -- Extra environment variables to set
3131
envOverrides: {}
3232

33+
# secrets -- List of Kubernetes secrets to be mounted. These secrets will be mounted on /etc/secrets/<secret name>.
34+
secrets: []
35+
3336
# podLabels -- Labels to be added to Feast Serving pods
3437
podLabels: {}

0 commit comments

Comments
 (0)