Skip to content

Commit a69aaae

Browse files
authored
fix: Fix release workflow to release 0.24.0 (#3138)
* Fix Signed-off-by: Kevin Zhang <[email protected]> * fix Signed-off-by: Kevin Zhang <[email protected]> * temporary fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> * Fix Signed-off-by: Kevin Zhang <[email protected]> Signed-off-by: Kevin Zhang <[email protected]>
1 parent 9f78367 commit a69aaae

File tree

2 files changed

+35
-32
lines changed

2 files changed

+35
-32
lines changed

.github/workflows/build_wheels.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ jobs:
8989
make install-go-ci-dependencies
9090
git status
9191
git restore go.mod go.sum
92+
git restore sdk/python/feast/ui/yarn.lock
9293
CIBW_BEFORE_TEST: "cd {project} && git status"
9394
# py3.10 on MacOS does not work with Go so we have to install separately. Issue is tracked here: https://github.com/feast-dev/feast/issues/2881.
9495
- name: Build py310 specific wheels for macos
@@ -104,6 +105,7 @@ jobs:
104105
CIBW_BEFORE_BUILD: |
105106
git status
106107
git restore go.mod go.sum
108+
git restore sdk/python/feast/ui/yarn.lock
107109
brew install apache-arrow
108110
- uses: actions/upload-artifact@v2
109111
with:
@@ -136,6 +138,7 @@ jobs:
136138
make build-ui
137139
git status
138140
git restore go.mod go.sum
141+
git restore sdk/python/feast/ui/yarn.lock
139142
- name: Build
140143
run: |
141144
python3 setup.py sdist
@@ -232,7 +235,7 @@ jobs:
232235
- name: Smoke test
233236
run: |
234237
feast init test_repo
235-
cd test_repo/
238+
cd test_repo/feature_repo
236239
feast apply
237240
echo "$TEST_SCRIPT" > run-and-wait.sh
238241
bash run-and-wait.sh feast serve
@@ -241,7 +244,7 @@ jobs:
241244
- name: Smoke test with go
242245
if: matrix.python-version != '3.10' || matrix.os == 'ubuntu-latest'
243246
run: |
244-
cd test_repo/
247+
cd test_repo/feature_repo
245248
feast apply
246249
echo "$TEST_SCRIPT" > run-and-wait.sh
247250
pip install cffi

.github/workflows/release.yml

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -42,40 +42,40 @@ jobs:
4242
echo "Current version is ${CURRENT_VERSION}"
4343
echo "Next version is ${NEXT_VERSION}"
4444
45-
publish-web-ui-npm:
46-
if: github.repository == 'feast-dev/feast'
47-
needs: get_dry_release_versions
48-
runs-on: ubuntu-latest
49-
env:
50-
# This publish is working using an NPM automation token to bypass 2FA
51-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
52-
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
53-
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
54-
steps:
55-
- uses: actions/checkout@v2
56-
- uses: actions/setup-node@v2
57-
with:
58-
node-version: '17.x'
59-
registry-url: 'https://registry.npmjs.org'
60-
- name: Bump file versions (temporarily for Web UI publish)
61-
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
62-
- name: Install yarn dependencies
63-
working-directory: ./ui
64-
run: yarn install
65-
- name: Build yarn rollup
66-
working-directory: ./ui
67-
run: yarn build:lib
68-
- name: Publish UI package
69-
working-directory: ./ui
70-
run: npm publish
71-
env:
72-
# This publish is working using an NPM automation token to bypass 2FA
73-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
45+
# publish-web-ui-npm:
46+
# if: github.repository == 'feast-dev/feast'
47+
# needs: get_dry_release_versions
48+
# runs-on: ubuntu-latest
49+
# env:
50+
# # This publish is working using an NPM automation token to bypass 2FA
51+
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
52+
# CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
53+
# NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
54+
# steps:
55+
# - uses: actions/checkout@v2
56+
# - uses: actions/setup-node@v2
57+
# with:
58+
# node-version: '17.x'
59+
# registry-url: 'https://registry.npmjs.org'
60+
# - name: Bump file versions (temporarily for Web UI publish)
61+
# run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
62+
# - name: Install yarn dependencies
63+
# working-directory: ./ui
64+
# run: yarn install
65+
# - name: Build yarn rollup
66+
# working-directory: ./ui
67+
# run: yarn build:lib
68+
# - name: Publish UI package
69+
# working-directory: ./ui
70+
# run: npm publish
71+
# env:
72+
# # This publish is working using an NPM automation token to bypass 2FA
73+
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
7474

7575
release:
7676
name: release
7777
runs-on: ubuntu-latest
78-
needs: publish-web-ui-npm
78+
#needs: publish-web-ui-npm
7979
env:
8080
GITHUB_TOKEN: ${{ github.event.inputs.token }}
8181
GIT_AUTHOR_NAME: feast-ci-bot

0 commit comments

Comments
 (0)