Skip to content

Commit 4934d84

Browse files
authored
fix: Enable faulthandler and disable flaky tests (#2815)
* fix: Enable faulthandler to get a coredump on segfaults for embedded go fs Signed-off-by: Achal Shah <[email protected]> * disable goserver from tests Signed-off-by: Achal Shah <[email protected]>
1 parent cb23648 commit 4934d84

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

sdk/python/feast/embedded_go/online_features_service.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import faulthandler
12
from functools import partial
23
from pathlib import Path
34
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Union
@@ -51,6 +52,7 @@ def __init__(
5152
),
5253
self._transformation_callback,
5354
)
55+
faulthandler.enable()
5456

5557
def get_online_features(
5658
self,

sdk/python/tests/integration/e2e/test_go_feature_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_go_grpc_server(grpc_client):
148148

149149

150150
@pytest.mark.integration
151-
@pytest.mark.goserver
151+
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
152152
def test_go_http_server(http_server_port):
153153
response = requests.post(
154154
f"http://localhost:{http_server_port}/get-online-features",
@@ -186,7 +186,7 @@ def test_go_http_server(http_server_port):
186186

187187

188188
@pytest.mark.integration
189-
@pytest.mark.goserver
189+
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
190190
@pytest.mark.universal_offline_stores
191191
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
192192
def test_feature_logging(

sdk/python/tests/integration/online_store/test_universal_online.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ def test_online_retrieval_with_event_timestamps(
443443

444444
@pytest.mark.integration
445445
@pytest.mark.universal_online_stores
446-
@pytest.mark.goserver
446+
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
447447
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
448448
def test_stream_feature_view_online_retrieval(
449449
environment, universal_data_sources, feature_server_endpoint, full_feature_names
@@ -519,7 +519,7 @@ def test_stream_feature_view_online_retrieval(
519519

520520
@pytest.mark.integration
521521
@pytest.mark.universal_online_stores
522-
@pytest.mark.goserver
522+
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
523523
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
524524
def test_online_retrieval(
525525
environment, universal_data_sources, feature_server_endpoint, full_feature_names

0 commit comments

Comments
 (0)