Skip to content

Commit 1ee39fe

Browse files
achalsadchia
authored andcommitted
chore: Remove rest settings from java app properties (#3155)
The rest setting was not being used since the java server moved to being gRPC only. Specifying it is only likely to cause warnings/errors and confusion. Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Achal Shah <[email protected]>
1 parent cadc91e commit 1ee39fe

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

java/serving/src/main/java/feast/serving/service/config/ApplicationProperties.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public class ApplicationProperties {
3838
private static final Logger log = org.slf4j.LoggerFactory.getLogger(ApplicationProperties.class);
3939
private FeastProperties feast;
4040
private GrpcServer grpc;
41-
private RestServer rest;
4241

4342
public FeastProperties getFeast() {
4443
return feast;
@@ -331,18 +330,6 @@ public void setServer(Server server) {
331330
}
332331
}
333332

334-
public static class RestServer {
335-
private Server server;
336-
337-
public Server getServer() {
338-
return server;
339-
}
340-
341-
public void setServer(Server server) {
342-
this.server = server;
343-
}
344-
}
345-
346333
/** Trace metric collection properties */
347334
public static class TracingProperties {
348335

java/serving/src/main/java/feast/serving/service/config/ApplicationPropertiesModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717
package feast.serving.service.config;
1818

19+
import com.fasterxml.jackson.databind.DeserializationFeature;
1920
import com.fasterxml.jackson.databind.ObjectMapper;
2021
import com.fasterxml.jackson.databind.ObjectReader;
2122
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
@@ -40,6 +41,7 @@ public ApplicationProperties provideApplicationProperties() throws IOException {
4041
ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
4142
mapper.findAndRegisterModules();
4243
mapper.setDefaultMergeable(Boolean.TRUE);
44+
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
4345

4446
ApplicationProperties properties = new ApplicationProperties();
4547
ObjectReader objectReader = mapper.readerForUpdating(properties);

0 commit comments

Comments
 (0)