Skip to content

Commit 156c6f1

Browse files
achalsadchia
authored andcommitted
ci: Use buildx for docker builds in remaining places as well (#2705)
* ci: Use buildx for docker builds in remaining places as well Signed-off-by: Achal Shah <[email protected]> * fix oops Signed-off-by: Achal Shah <[email protected]>
1 parent 1f893f1 commit 156c6f1

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ Note that this means if you are midway through working through a PR and rebase,
7575
## Feast Python SDK / CLI
7676
### Environment Setup
7777
Setting up your development environment for Feast Python SDK / CLI:
78-
1. Ensure that you have Docker installed in your environment. Docker is used to provision service dependencies during testing.
78+
1. Ensure that you have Docker installed in your environment. Docker is used to provision service dependencies during testing, and build images for feature servers and other components.
79+
1. Please note that we use [Docker with BuiltKit](https://docs.docker.com/develop/develop-images/build_enhancements/).
7980
2. Ensure that you have `make`, Python (3.7 and above) with `pip`, installed.
8081
3. _Recommended:_ Create a virtual environment to isolate development dependencies to be installed
8182
```sh

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ push-ci-docker:
206206

207207
# TODO(adchia): consider removing. This doesn't run successfully right now
208208
build-ci-docker:
209-
docker build -t $(REGISTRY)/feast-ci:$(VERSION) -f infra/docker/ci/Dockerfile .
209+
docker buildx build -t $(REGISTRY)/feast-ci:$(VERSION) -f infra/docker/ci/Dockerfile --load .
210210

211211
push-feature-server-python-aws-docker:
212212
docker push $(REGISTRY)/feature-server-python-aws:$$VERSION
@@ -228,9 +228,9 @@ push-feature-server-java-docker:
228228
docker push $(REGISTRY)/feature-server-java:$(VERSION)
229229

230230
build-feature-server-java-docker:
231-
docker build --build-arg VERSION=$(VERSION) \
231+
docker buildx build --build-arg VERSION=$(VERSION) \
232232
-t $(REGISTRY)/feature-server-java:$(VERSION) \
233-
-f java/infra/docker/feature-server/Dockerfile .
233+
-f java/infra/docker/feature-server/Dockerfile --load .
234234

235235
# Documentation
236236

0 commit comments

Comments
 (0)