Skip to content

Commit 0439945

Browse files
authored
docs: Fix rtd docs by removing mysqlclient (#2778)
* docs: Fix rtd docs by removing mysqlclient Signed-off-by: Achal Shah <[email protected]> * fixes Signed-off-by: Achal Shah <[email protected]> * rm dockerfile Signed-off-by: Achal Shah <[email protected]>
1 parent 4ed107c commit 0439945

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.readthedocs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ formats:
77
- pdf
88

99
python:
10-
version: 3.7
10+
version: "3.8"
1111
install:
1212
- requirements: sdk/python/docs/requirements.txt

sdk/python/docs/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-e ".[ci]"
1+
-e ".[docs]"

setup.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,13 @@
178178
+ HBASE_REQUIRED
179179
)
180180

181+
182+
# rtd builds fail because of mysql not being installed in their environment.
183+
# We can add mysql there, but it's not strictly needed. This will be faster for builds.
184+
DOCS_REQUIRED = CI_REQUIRED
185+
for _r in MYSQL_REQUIRED:
186+
DOCS_REQUIRED.remove(_r)
187+
181188
DEV_REQUIRED = ["mypy-protobuf==3.1", "grpcio-testing==1.*"] + CI_REQUIRED
182189

183190
# Get git repo root directory
@@ -480,6 +487,7 @@ def copy_extensions_to_source(self):
480487
"ge": GE_REQUIRED,
481488
"hbase": HBASE_REQUIRED,
482489
"go": GO_REQUIRED,
490+
"docs": DOCS_REQUIRED,
483491
},
484492
include_package_data=True,
485493
license="Apache",

0 commit comments

Comments
 (0)