fix: keep sdkVersion property always up-to-date with the correct version of the SDK #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Jul 11, 2024
| add_builtin(fastly::cache_override SRC builtins/cache-override.cpp) | ||
| add_builtin(fastly::fetch_event SRC builtins/fetch-event.cpp DEPENDENCIES OpenSSL) | ||
|
|
||
| add_compile_definitions(PUBLIC RUNTIME_VERSION=${RUNTIME_VERSION}) |
Contributor
There was a problem hiding this comment.
Added this line and verified with a local build the string starlingmonkey-3.16.2 is being correctly inlined.
guybedford
approved these changes
Jul 11, 2024
JakeChampion
force-pushed
the
jake/sdk-version-property
branch
from
0b2d557 to
f57d77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.