fix: support cacheKey in Request init #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
cacheKeyinRequestinitialization, which was previously omitted, and fixes the test case that was supposed to test for this.We don't use an internal slot for
cacheKeysince it is effectively a header-manipulating function, where that header manipulation is observable to users. If we want to use an internal slot, that would be a breaking change at this point to provide a header alteration from such a slot that exists only as observable to the host.Note that this is implemented in the parallel StarlingMonkey branch while this port is in progress... a fact of life during this port process!
Resolves #768.