fix: modular builtin separation #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
approved these changes
Feb 28, 2023
JakeChampion
force-pushed
the
guybedford/builtins-separation
branch
from
0906ab9 to
f8ace20
Compare
JakeChampion
force-pushed
the
guybedford/builtins-separation
branch
from
f8ace20 to
26753e6
Compare
elliottt
approved these changes
Feb 28, 2023
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully separates the builtins build by including the
encodefunction and also including a customGetErrorMessageBuiltinwith separate builtin error message codes so that the error message pipeline for the builtins is completely separated from the Fastly-specific code.Structuring feedback very welcome, but I can confirm this works for building the console against ComponentizeJS.