fix: add custom error message when making a request to a backend which does not exist #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Feb 8, 2023
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Is there an XQD issue to track an error code for this?
Contributor
Author
There is not, I believe the plan is to not introduce new error codes (until we move to components) |
…h does not exist previously we would return the generic message: "Generic error value. This means that some unexpected error occurred during a hostcall."
JakeChampion
force-pushed
the
jake/backend-missing-message
branch
from
fb0b8f8 to
046d2eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we would return the generic message: "Generic error value. This means that some unexpected error occurred during a hostcall."
Now we will return a TypeError with the message format
Requested backend named '{0}' does not existwhere{0}is the name of the backend that was configured for the request.