feat: implement SubtleCrypto.prototype.digest method #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
3 times, most recently
from
6c474f9 to
73bdfb6
Compare
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
2 times, most recently
from
23fdbf5 to
25c1078
Compare
elliottt
reviewed
Jan 18, 2023
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Looking good! Just a few comments about avoiding copies when possible.
tests/wpt-harness/expectations/WebCryptoAPI/idlharness.https.any.js.json
Show resolved
Hide resolved
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
4 times, most recently
from
c07ebc9 to
0a3d5dc
Compare
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
from
0a3d5dc to
8eee88f
Compare
elliottt
approved these changes
Jan 24, 2023
Contributor
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Looks great! I just had one suggestion for removing an unused vector.
| builtins::CryptoAlgorithmIdentifier::AES_KW, builtins::CryptoAlgorithmIdentifier::HMAC, | ||
| builtins::CryptoAlgorithmIdentifier::HKDF, builtins::CryptoAlgorithmIdentifier::PBKDF2}; | ||
| } // namespace | ||
| namespace builtins { |
Contributor
There was a problem hiding this comment.
No need to change this, but it's totally fine to nest anonymous namespaces within another -- it would have been fine to leave the definition of the builtins namespace on line 25.
added 3 commits
January 24, 2023 10:19
This commit is the start towards full SubtleCrypto support in the runtime. I've implemented the `SubtleCrypto` class but with only one method so far, `SubtleCrypto.prototype.digest`. I've made `globalThis.crypto` become an instance of `Crypto` and have added an instance of `SubtleCrypto` as a getter on `Crypto.prototype.subtle` as per the [WebIDL specification](https://w3c.github.io/webcrypto/#webidl-1120328020): ```webidl partial interface mixin WindowOrWorkerGlobalScope { [SameObject] readonly attribute Crypto crypto; }; [Exposed] interface Crypto { [SecureContext] readonly attribute SubtleCrypto subtle; ArrayBufferView getRandomValues(ArrayBufferView array); [SecureContext] DOMString randomUUID(); }; ``` Currently 76 out of 80 of the Web Platform Tests pass for `SubtleCrypto.prototype.digest`, the ones which fail are to do with providing a large `data` parameter and altering the `data` parameter's buffer after calling `SubtleCrypto.prototype.digest`. I'm not sure yet as to why these tests are failing, it is confusing for me as the same test but with a smaller `data` parameter does pass as expected.
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
2 times, most recently
from
416e575 to
f86b3d8
Compare
Co-authored-by: Trevor Elliott <[email protected]>
JakeChampion
force-pushed
the
jake/subtlecrypto-digest
branch
from
f86b3d8 to
bfbadb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is the start towards full SubtleCrypto support in the runtime.
I've implemented the
SubtleCryptoclass but with only one method so far,SubtleCrypto.prototype.digest.I've made
globalThis.cryptobecome an instance ofCryptoand have added an instance ofSubtleCryptoas a getter onCrypto.prototype.subtleas per the WebIDL specification:Remaining parts to add in this pull-request:
subtleproperty.SubtleCryptoSubtleCrypto.prototype.digest