Fix: make shielding.d.ts ambient #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced top-level import with inline import() and a triple-slash reference to keep the file ambient. This aligns with other fastly:* declarations and resolves consumer import failure.
cromery
force-pushed
the
fix/shielding-module
branch
from
ca39eb6 to
fae2eb8
Compare
cromery
changed the title
TartanLlama
approved these changes
Dec 17, 2025
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to try out Shielding, but was not possible to import with our typescript setup.
Replaced top-level import with inline import() and a triple-slash reference to keep the file ambient. This aligns with other
fastly:*declarations and resolves consumer import failure.Added a tsd test to make sure the module resolves correctly.
Complied and installed it from the local package to our main compute application. Ran it locally (without shielding) as well as deployed to our preprod environment with shielding, works well.