Skip to content

Commit db4353c

Browse files
committed
Refactor: remove useless parameter (#25923)
## Summary I was reading the source code of `ReactFiberLane.js` and I found the third parameter of the function markRootPinged was not used. So I think we can remove it. ## How did you test this change? There is no logic changed, so I think there is no need to add unit tests. So I run `yarn test` and `yarn test --prod` locally and all tests are passed. Co-authored-by: Jan Kassens <[email protected]> DiffTrain build for [afe6521](afe6521) [View git log for this commit](https://github.com/facebook/react/commits/afe6521e134178920f0523ede4c715942d8f0564)
1 parent 6283e19 commit db4353c

28 files changed

+158
-158
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1253462ea48db362faad864695a172f5a56759ca
1+
afe6521e134178920f0523ede4c715942d8f0564
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1253462ea48db362faad864695a172f5a56759ca
1+
afe6521e134178920f0523ede4c715942d8f0564

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-1253462ea-20230109";
30+
var ReactVersion = "18.3.0-www-classic-afe6521e1-20230109";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-1253462ea-20230109";
30+
var ReactVersion = "18.3.0-www-modern-afe6521e1-20230109";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
643643
);
644644
};
645645
exports.useTransition = useTransition;
646-
exports.version = "18.3.0-www-classic-1253462ea-20230109";
646+
exports.version = "18.3.0-www-classic-afe6521e1-20230109";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
635635
);
636636
};
637637
exports.useTransition = useTransition;
638-
exports.version = "18.3.0-www-modern-1253462ea-20230109";
638+
exports.version = "18.3.0-www-modern-afe6521e1-20230109";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
654654
);
655655
};
656656
exports.useTransition = useTransition;
657-
exports.version = "18.3.0-www-classic-1253462ea-20230109";
657+
exports.version = "18.3.0-www-classic-afe6521e1-20230109";
658658

659659
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
660660
if (

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
646646
);
647647
};
648648
exports.useTransition = useTransition;
649-
exports.version = "18.3.0-www-modern-1253462ea-20230109";
649+
exports.version = "18.3.0-www-modern-afe6521e1-20230109";
650650

651651
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
652652
if (

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-1253462ea-20230109";
72+
var ReactVersion = "18.3.0-www-classic-afe6521e1-20230109";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -2232,7 +2232,7 @@ function markRootSuspended(root, suspendedLanes) {
22322232
lanes &= ~lane;
22332233
}
22342234
}
2235-
function markRootPinged(root, pingedLanes, eventTime) {
2235+
function markRootPinged(root, pingedLanes) {
22362236
root.pingedLanes |= root.suspendedLanes & pingedLanes;
22372237
}
22382238
function markRootMutableRead(root, updateLane) {

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-1253462ea-20230109";
72+
var ReactVersion = "18.3.0-www-modern-afe6521e1-20230109";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;
@@ -2229,7 +2229,7 @@ function markRootSuspended(root, suspendedLanes) {
22292229
lanes &= ~lane;
22302230
}
22312231
}
2232-
function markRootPinged(root, pingedLanes, eventTime) {
2232+
function markRootPinged(root, pingedLanes) {
22332233
root.pingedLanes |= root.suspendedLanes & pingedLanes;
22342234
}
22352235
function markRootMutableRead(root, updateLane) {

0 commit comments

Comments
 (0)