Skip to content

Commit c5d356f

Browse files
author
Pascal Fong Kye
committed
Update eslint to v7.7.0
Update hook test since eslint now supports nullish coalescing
1 parent 0b0c734 commit c5d356f

File tree

3 files changed

+125
-193
lines changed

3 files changed

+125
-193
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"create-react-class": "^15.6.3",
4848
"danger": "^9.2.10",
4949
"error-stack-parser": "^2.0.6",
50-
"eslint": "^7.0.0",
50+
"eslint": "^7.7.0",
5151
"eslint-config-fbjs": "^1.1.1",
5252
"eslint-config-prettier": "^6.9.0",
5353
"eslint-plugin-babel": "^5.3.0",

packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -752,9 +752,7 @@ const tests = {
752752
errors: [
753753
conditionalError('useState'),
754754
conditionalError('useState'),
755-
// TODO: ideally this *should* warn, but ESLint
756-
// doesn't plan full support for ?? until it advances.
757-
// conditionalError('useState'),
755+
conditionalError('useState'),
758756
],
759757
},
760758
{

0 commit comments

Comments
 (0)