Skip to content

Commit 9aaa3ed

Browse files
carsonipf7o
authored andcommitted
[exporter/elasticsearch] Change default retry.retry_to_status to [429] (open-telemetry#34684)
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Breaking change to change default retry_on_status to 429 **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#32584 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
1 parent ac3e6ff commit 9aaa3ed

File tree

3 files changed

+29
-5
lines changed

3 files changed

+29
-5
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: elasticsearchexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Change default retry.retry_on_status to [429]
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [32584]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
To retain the previous behavior, set retry.retry_on_status to `[429, 500, 502, 503, 504]`.
20+
21+
# If your change doesn't affect end users or the exported elements of any package,
22+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
23+
# Optional: The change log or logs in which this entry should be included.
24+
# e.g. '[user]' or '[user, api]'
25+
# Include 'user' if the change is relevant to end users.
26+
# Include 'api' if there is a change to a library API.
27+
# Default: '[user]'
28+
change_logs: [user]

exporter/elasticsearchexporter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ The behaviour of this bulk indexing can be configured with the following setting
198198
- `max_requests` (default=3): Number of HTTP request retries.
199199
- `initial_interval` (default=100ms): Initial waiting time if a HTTP request failed.
200200
- `max_interval` (default=1m): Max waiting time if a HTTP request failed.
201-
- `retry_on_status` (default=[429, 500, 502, 503, 504]): Status codes that trigger request or document level retries. Request level retry and document level retry status codes are shared and cannot be configured separately. To avoid duplicates, it is recommended to set it to `[429]`. WARNING: The default will be changed to `[429]` in the future.
201+
- `retry_on_status` (default=[429]): Status codes that trigger request or document level retries. Request level retry and document level retry status codes are shared and cannot be configured separately. To avoid duplicates, it defaults to `[429]`.
202202

203203
> [!NOTE]
204204
> The `flush` config will be ignored when `batcher::enabled` config is explicitly set to `true` or `false`.

exporter/elasticsearchexporter/factory.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ func createDefaultConfig() component.Config {
6969
MaxInterval: 1 * time.Minute,
7070
RetryOnStatus: []int{
7171
http.StatusTooManyRequests,
72-
http.StatusInternalServerError,
73-
http.StatusBadGateway,
74-
http.StatusServiceUnavailable,
75-
http.StatusGatewayTimeout,
7672
},
7773
},
7874
Mapping: MappingsSettings{

0 commit comments

Comments
 (0)