Skip to content

Commit 8a161a5

Browse files
Felipe Lopesf7o
authored andcommitted
[receiver/datadogreceiver] Include error when logging unmarshaling failures (open-telemetry#34515)
This helped us to identify empty buffer errors.
1 parent 6b5c7b2 commit 8a161a5

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: datadogreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "Include error when logging unmarshaling failures in Datadog receiver."
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [34515]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

receiver/datadogreceiver/receiver.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques
119119
ddTraces, err = translator.HandleTracesPayload(req)
120120
if err != nil {
121121
http.Error(w, "Unable to unmarshal reqs", http.StatusBadRequest)
122-
ddr.params.Logger.Error("Unable to unmarshal reqs")
122+
ddr.params.Logger.Error("Unable to unmarshal reqs", zap.Error(err))
123123
return
124124
}
125125
for _, ddTrace := range ddTraces {
@@ -128,7 +128,7 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques
128128
err = ddr.nextTracesConsumer.ConsumeTraces(obsCtx, otelTraces)
129129
if err != nil {
130130
http.Error(w, "Trace consumer errored out", http.StatusInternalServerError)
131-
ddr.params.Logger.Error("Trace consumer errored out")
131+
ddr.params.Logger.Error("Trace consumer errored out", zap.Error(err))
132132
return
133133
}
134134
}

0 commit comments

Comments
 (0)