Merge pull request #10 from carlosV2/master

Support PHP 5.3

Author: everzet

.travis.yml

@@ -1,6 +1,6 @@
 language: php
 
-php: [5.4, 5.5, 5.6, 7.0, 7.1, hhvm]
+php: [5.3, 5.4, 5.5, 5.6, 7.0, 7.1, hhvm]
 
 branches:
   except:

composer.json

@@ -13,7 +13,7 @@
         }
     ],
     "require": {
-        "php": ">5.4,<7.2"
+        "php": ">5.3,<7.2"
     },
 
     "require-dev": {

src/CallbackObjectIdentifier.php

@@ -6,7 +6,7 @@ final class CallbackObjectIdentifier implements ObjectIdentifier
 {
     private $callable;
 
-    public function __construct(callable $callable)
+    public function __construct($callable)
     {
         $this->callable = $callable;
     }

src/FileRepository.php

@@ -49,7 +49,7 @@ public function getAll()
 
     public function clear()
     {
-        $this->saveDb([]);
+        $this->saveDb(array());
     }
 
     private function getIdentity($object)
@@ -67,7 +67,7 @@ private function loadDb()
         if (null === $this->cache) {
             $this->cache = file_exists($this->filename)
                 ? unserialize(file_get_contents($this->filename))
-                : [];
+                : array();
         }
 
         return $this->cache;

src/InMemoryRepository.php

@@ -5,7 +5,7 @@
 final class InMemoryRepository implements Repository
 {
     private $identifier;
-    private $storage = [];
+    private $storage = array();
 
     public function __construct(ObjectIdentifier $identifier)
     {
@@ -42,7 +42,7 @@ public function getAll()
 
     public function clear()
     {
-        $this->storage = [];
+        $this->storage = array();
     }
 
     private function getIdentity($object)

tests/FileRepositoryTest.php

@@ -38,10 +38,10 @@ protected function tearDown()
 
     /** @test */ function shouldOverrideObjectsWithTheSameId()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new PersistedObject($objectId = 42, 'everzet'),
             new PersistedObject($objectId, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
@@ -53,7 +53,7 @@ protected function tearDown()
     /** @test @expectedException Exception */
     function shouldThrowAnExceptionIfUnexpectedObjectGiven()
     {
-        $objectToPersist = (object)[];
+        $objectToPersist = (object) array();
         $repository = $this->createRepository();
 
         $repository->save($objectToPersist);
@@ -77,15 +77,15 @@ function shouldThrowAnExceptionIfUnexpectedObjectGiven()
 
         $repository->remove($objectToPersist);
 
-        $this->assertEquals([], $repository->getAll());
+        $this->assertEquals(array(), $repository->getAll());
     }
 
     /** @test */ function shouldBeAbleToGetAllObjects()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new PersistedObject(42, 'everzet'),
             new PersistedObject(24, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
@@ -98,10 +98,10 @@ function shouldThrowAnExceptionIfUnexpectedObjectGiven()
 
     /** @test */ function shouldPersistObjectsBetweenInstances()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new PersistedObject(42, 'everzet'),
             new PersistedObject(24, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
         $newRepository = $this->createRepository();
 
@@ -113,18 +113,18 @@ function shouldThrowAnExceptionIfUnexpectedObjectGiven()
 
     /** @test */ function shouldBeAbleToClearRepository()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new PersistedObject(42, 'everzet'),
             new PersistedObject(24, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
         $newRepository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
         $repository->save($objectsToPersist[1]);
         $repository->clear();
 
-        $this->assertEquals([], $repository->getAll());
+        $this->assertEquals(array(), $repository->getAll());
         $this->assertEquals($newRepository->getAll(), $repository->getAll());
     }
 

tests/InMemoryRepositoryTest.php

@@ -27,10 +27,10 @@ class InMemoryRepositoryTest extends PHPUnit_Framework_TestCase
 
     /** @test */ function shouldOverrideObjectsWithTheSameId()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new InMemoryObject($objectId = 42, 'everzet'),
             new InMemoryObject($objectId, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
@@ -57,15 +57,15 @@ class InMemoryRepositoryTest extends PHPUnit_Framework_TestCase
 
         $repository->remove($objectToPersist);
 
-        $this->assertEquals([], $repository->getAll());
+        $this->assertEquals(array(), $repository->getAll());
     }
 
     /** @test */ function shouldBeAbleToGetAllObjects()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new InMemoryObject(42, 'everzet'),
             new InMemoryObject(24, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
@@ -76,17 +76,17 @@ class InMemoryRepositoryTest extends PHPUnit_Framework_TestCase
 
     /** @test */ function shouldBeAbleToClearRepository()
     {
-        $objectsToPersist = [
+        $objectsToPersist = array(
             new InMemoryObject(42, 'everzet'),
             new InMemoryObject(24, 'marcello')
-        ];
+        );
         $repository = $this->createRepository();
 
         $repository->save($objectsToPersist[0]);
         $repository->save($objectsToPersist[1]);
         $repository->clear();
 
-        $this->assertEquals([], $repository->getAll());
+        $this->assertEquals(array(), $repository->getAll());
     }
 
     private function createRepository()