Skip to content

Commit 8a555f0

Browse files
authored
Remove the LoopIntervalMsec from liveness_expiration + withdrawals_mon. (#50)
* remove: `LoopIntervalMsec` from withdrawals_mon. * remove: `LoopIntervalMsec` useless logic from LivenessExpiration.
1 parent 54f0c69 commit 8a555f0

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

op-monitorism/liveness_expiration/cli.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package liveness_expiration
22

33
import (
4-
"errors"
54
"github.com/ethereum/go-ethereum/common"
65

76
opservice "github.com/ethereum-optimism/optimism/op-service"
@@ -17,13 +16,11 @@ const (
1716
SafeAddressFlagName = "safe.address"
1817
LivenessModuleAddressFlagName = "livenessmodule.address"
1918
LivenessGuardAddressFlagName = "livenessguard.address"
20-
LoopIntervalMsecFlagName = "loop.interval.msec"
2119
)
2220

2321
type CLIConfig struct {
2422
L1NodeURL string
2523
EventBlockRange uint64
26-
LoopIntervalMsec uint64
2724
StartingL1BlockHeight uint64
2825

2926
LivenessModuleAddress common.Address
@@ -36,16 +33,11 @@ func ReadCLIFlags(ctx *cli.Context) (CLIConfig, error) {
3633
L1NodeURL: ctx.String(L1NodeURLFlagName),
3734
EventBlockRange: ctx.Uint64(EventBlockRangeFlagName),
3835
StartingL1BlockHeight: ctx.Uint64(StartingL1BlockHeightFlagName),
39-
LoopIntervalMsec: ctx.Uint64(LoopIntervalMsecFlagName),
4036
SafeAddress: common.HexToAddress(ctx.String(SafeAddressFlagName)),
4137
LivenessModuleAddress: common.HexToAddress(ctx.String(LivenessModuleAddressFlagName)),
4238
LivenessGuardAddress: common.HexToAddress(ctx.String(LivenessGuardAddressFlagName)),
4339
}
4440

45-
if cfg.LoopIntervalMsec == 0 {
46-
return cfg, errors.New("no loop interval configured")
47-
}
48-
4941
return cfg, nil
5042
}
5143

op-monitorism/liveness_expiration/monitor.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ func NewMonitor(ctx context.Context, log log.Logger, m metrics.Factory, cfg CLIC
7575
log.Info("", "Safe Address", cfg.SafeAddress)
7676
log.Info("", "LivenessModuleAddress", cfg.LivenessModuleAddress)
7777
log.Info("", "LivenessGuardAddress", cfg.LivenessGuardAddress)
78-
log.Info("", "Interval", cfg.LoopIntervalMsec)
7978
log.Info("", "L1RpcUrl", cfg.L1NodeURL)
8079
log.Info("--------------------------- End of Infos -------------------------------------------------------")
8180

op-monitorism/withdrawals/cli.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ type CLIConfig struct {
2525
L2NodeURL string
2626

2727
EventBlockRange uint64
28-
LoopIntervalMsec uint64
2928
StartingL1BlockHeight uint64
3029

3130
OptimismPortalAddress common.Address

0 commit comments

Comments
 (0)