Fix clang tidy errors

Author: equalsraf

src/gui/app.cpp

@@ -24,7 +24,7 @@ int s_exitStatus{ 0 };
 
 struct ConnectorInitArgs
 {
-	enum class Type
+	enum class Type : std::int8_t
 	{
 		Embed,
 		Server,
@@ -43,6 +43,10 @@ struct ConnectorInitArgs
 
 	ConnectorInitArgs(
 		Type _type, int _timeout, QString _server, QString _nvim, QStringList nvimArgs) noexcept;
+
+	// non copyable - we don't need it and it triggers lint warnings on const members
+	ConnectorInitArgs(const ConnectorInitArgs&) = delete;
+	ConnectorInitArgs& operator=(const ConnectorInitArgs&) = delete;
 };
 
 ConnectorInitArgs::Type getConnectorType(const QCommandLineParser& parser) noexcept

src/gui/popupmenu.cpp

@@ -61,7 +61,8 @@ void PopupMenu::setGeometry(int64_t row, int64_t col)
 		const int height = sizeHintContent.height();
 
 		qDebug() << "Fallback: PUM anchored to 0,0 without parent shell_widget!";
-		return QListView::setGeometry(0, 0, width, height);
+		QListView::setGeometry(0, 0, width, height);
+		return;
 	}
 
 	const int cell_width = m_parentShellWidget->cellSize().width();
@@ -124,7 +125,7 @@ void PopupMenu::setGeometry(int64_t row, int64_t col)
 		anchor_y = (row + 1) * cell_height;
 	}
 
-	return QListView::setGeometry(anchor_x, anchor_y, width, height);
+	QListView::setGeometry(anchor_x, anchor_y, width, height);
 }
 
 } // Namespace