Detect conflicts between exported types and FQNs (#5986)

Exporting types named the same as the module where they are defined in `Main` modules of library components may lead to accidental name conflicts. This became apparent when trying to access `Problem_Behavior` module via a fully qualified name and the compiler rejected it. This is due to the fact that `Main` module exported `Error` type defined in `Standard.Base.Error` module, thus making it impossible to access any other submodules of `Standard.Base.Error` via a fully qualified name.

This change adds a warning to FullyQualifiedNames pass that detects any such future problems.
While only `Error` module was affected, it was widely used in the stdlib, hence the number of changes.

Closes #5902.

# Important Notes
I left out the potential conflict in micro-distribution, thus ensuring we actually detect and report the warning.

Author: hubertp

CHANGELOG.md

@@ -646,6 +646,7 @@
 - [Merge ordered and unordered comparators][5845]
 - [Use SHA-1 for calculating hashes of modules' IR and bindings][5791]
 - [Don't install Python component on Windows][5900]
+- [Detect potential name conflicts between exported types and FQNs][5966]
 
 [3227]: https://github.com/enso-org/enso/pull/3227
 [3248]: https://github.com/enso-org/enso/pull/3248
@@ -747,6 +748,7 @@
 [5845]: https://github.com/enso-org/enso/pull/5845
 [5791]: https://github.com/enso-org/enso/pull/5791
 [5900]: https://github.com/enso-org/enso/pull/5900
+[5966]: https://github.com/enso-org/enso/pull/5966
 
 # Enso 2.0.0-alpha.18 (2021-10-12)
 

distribution/lib/Standard/Base/0.0.0-dev/src/Any.enso

@@ -2,9 +2,9 @@ import project.Data.Pair.Pair
 import project.Data.Range.Extensions
 import project.Data.Text.Text
 import project.Error.Error
-import project.Error.Common.Incomparable_Values
-import project.Error.Common.No_Such_Conversion
-import project.Error.Common.Type_Error
+import project.Errors.Common.Incomparable_Values
+import project.Errors.Common.No_Such_Conversion
+import project.Errors.Common.Type_Error
 import project.Nothing.Nothing
 import project.Meta
 import project.Panic.Panic

distribution/lib/Standard/Base/0.0.0-dev/src/Data.enso

@@ -4,9 +4,9 @@ import project.Data.Text.Encoding.Encoding
 import project.Data.Text.Text
 import project.Data.Vector.Vector
 import project.Error.Error
-import project.Error.File_Error.File_Error
-import project.Error.Illegal_Argument.Illegal_Argument
-import project.Error.Problem_Behavior.Problem_Behavior
+import project.Errors.File_Error.File_Error
+import project.Errors.Illegal_Argument.Illegal_Argument
+import project.Errors.Problem_Behavior.Problem_Behavior
 import project.Meta
 import project.Network.URI.URI
 import project.Network.HTTP.Header.Header

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Array.enso

@@ -4,7 +4,7 @@ import project.Data.Ordering.Ordering
 import project.Data.Range.Extensions
 import project.Data.Text.Text
 import project.Data.Vector.Vector
-import project.Error.Common.Index_Out_Of_Bounds
+import project.Errors.Common.Index_Out_Of_Bounds
 import project.Meta
 import project.Nothing.Nothing
 import project.Panic.Panic

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Array_Proxy.enso

@@ -1,7 +1,7 @@
 import project.Any.Any
 import project.Data.Array.Array
 import project.Data.Numbers.Integer
-import project.Error.Illegal_Argument.Illegal_Argument
+import project.Errors.Illegal_Argument.Illegal_Argument
 
 ## A helper type used for creating an array from a length and a callback
    providing its elements.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Index_Sub_Range.enso

@@ -3,9 +3,9 @@ import project.Data.Numbers.Integer
 import project.Data.Range.Range
 import project.Data.Range.Extensions
 import project.Data.Vector.Vector
-import project.Error.Common.Index_Out_Of_Bounds
+import project.Errors.Common.Index_Out_Of_Bounds
 import project.Error.Error
-import project.Error.Illegal_Argument.Illegal_Argument
+import project.Errors.Illegal_Argument.Illegal_Argument
 import project.Math
 import project.Panic.Panic
 import project.Random

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json.enso

@@ -10,10 +10,10 @@ import project.Data.Range.Extensions
 import project.Data.Text.Extensions
 import project.Data.Text.Text
 import project.Data.Vector.Vector
-import project.Error.Common.Type_Error
+import project.Errors.Common.Type_Error
 import project.Error.Error
-import project.Error.Illegal_Argument.Illegal_Argument
-import project.Error.No_Such_Key.No_Such_Key
+import project.Errors.Illegal_Argument.Illegal_Argument
+import project.Errors.No_Such_Key.No_Such_Key
 import project.Meta
 import project.Nothing.Nothing
 import project.Panic.Panic

distribution/lib/Standard/Base/0.0.0-dev/src/Data/List.enso

@@ -4,8 +4,8 @@ import project.Data.Numbers.Integer
 import project.Data.Numbers.Number
 import project.Data.Text.Text
 import project.Data.Vector.Vector
-import project.Error.Common.Index_Out_Of_Bounds
-import project.Error.Common.Not_Found
+import project.Errors.Common.Index_Out_Of_Bounds
+import project.Errors.Common.Not_Found
 import project.Error.Error
 import project.Function.Function
 import project.Nothing.Nothing

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Map.enso

@@ -3,8 +3,8 @@ import project.Data.Vector.Vector
 import project.Data.Pair.Pair
 import project.Data.Text.Extensions
 import project.Data.Text.Text
-import project.Error.Illegal_Argument.Illegal_Argument
-import project.Error.No_Such_Key.No_Such_Key
+import project.Errors.Illegal_Argument.Illegal_Argument
+import project.Errors.No_Such_Key.No_Such_Key
 
 from project.Data.Boolean import Boolean, True, False
 from project import Error, Nothing, Any, Panic

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Noise.enso

@@ -2,7 +2,7 @@ import project.Any.Any
 import project.Data.Interval.Bound
 import project.Data.Interval.Interval
 import project.Data.Numbers.Number
-import project.Error.Unimplemented.Unimplemented
+import project.Errors.Unimplemented.Unimplemented
 
 polyglot java import java.lang.Long
 polyglot java import java.util.Random