Skip to content

Commit 3a77d6c

Browse files
authored
Reduce legacy environment variable warning to debug message (#14968)
Fixes: emscripten-core/emsdk#862
1 parent 872b959 commit 3a77d6c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ def parse_config_file():
144144
elif key in config:
145145
globals()[key] = config[key]
146146

147-
# Handle legacy environment variables that were previously honored by the
148-
# default config file.
147+
# In the past the default-generated .emscripten config file would read certain environment
148+
# variables. We used generate a warning here but that could generates false positives
149+
# See https://github.com/emscripten-core/emsdk/issues/862
149150
LEGACY_ENV_VARS = {
150151
'LLVM': 'EM_LLVM_ROOT',
151152
'BINARYEN': 'EM_BINARYEN_ROOT',
@@ -154,8 +155,7 @@ def parse_config_file():
154155
for key, new_key in LEGACY_ENV_VARS.items():
155156
env_value = os.environ.get(key)
156157
if env_value and new_key not in os.environ:
157-
logger.warning(f'warning: honoring legacy environment variable `{key}`. Please switch to using `{new_key}` instead`')
158-
globals()[new_key] = env_value
158+
logger.debug(f'legacy environment variable found: `{key}`. Please switch to using `{new_key}` instead`')
159159

160160
# Certain keys are mandatory
161161
for key in ('LLVM_ROOT', 'NODE_JS', 'BINARYEN_ROOT'):

0 commit comments

Comments
 (0)