🔧 fix: transform schema inside query

Author: SaltyAom

CHANGELOG.md

@@ -1,5 +1,6 @@
 # 1.2.20 - 22 Feb 2025
 Bug fix:
+- [#671](https://github.com/elysiajs/elysia/issues/671#issuecomment-2675777040) Transform query schema check fails
 - model type
 
 # 1.2.19 - 22 Feb 2025

example/a.ts

@@ -1,18 +1,27 @@
 import { Elysia, t } from '../src'
 import { req } from '../test/utils'
 
-const p1 = new Elysia().model({
-	a: t.String()
-})
+const app = new Elysia().get(
+	'/test',
+	({ query: { id } }) => ({
+		id,
+		type: typeof id
+	}),
+	{
+		query: t.Object({
+			id: t
+				.Transform(t.Array(t.UnionEnum(['test', 'foo'])))
+				.Decode((id) => ({ value: id }))
+				.Encode((id) => id.value)
+		})
+	}
+)
 
-const p2 = new Elysia().model({
-	b: t.Number()
-})
-
-const app = new Elysia()
-	.use([p1, p2])
-	.model({
-		c: t.String()
-	})
-
-console.log(app.models)
+app.handle(req('/test?id=test'))
+	.then((x) =>
+	x.json().then((v) =>
+		console.dir(v, {
+			depth: null
+		})
+	)
+)

src/compose.ts

@@ -21,8 +21,7 @@ import {
 	redirect,
 	signCookie,
 	isNotEmpty,
-	encodePath,
-	replaceSchemaType
+	encodePath
 } from './utils'
 import { ParseError, error } from './error'
 
@@ -46,7 +45,7 @@ import type {
 	LifeCycleStore,
 	SchemaValidator
 } from './types'
-import { t, type TypeCheck } from './type-system'
+import { type TypeCheck } from './type-system'
 
 const TypeBoxSymbol = {
 	optional: Symbol.for('TypeBox.Optional'),

src/index.ts

@@ -633,20 +633,6 @@ export default class Elysia<
 						createQuery() {
 							if (this.query) return this.query
 
-							// console.dir(
-							// 	getSchemaValidator(cloned.query, {
-							// 		modules,
-							// 		dynamic,
-							// 		models,
-							// 		coerce: true,
-							// 		additionalCoerce:
-							// 			stringToStructureCoercions()
-							// 	}).schema,
-							// 	{
-							// 		depth: null
-							// 	}
-							// )
-
 							return (this.query = getSchemaValidator(
 								cloned.query,
 								{

src/type-system.ts

@@ -30,6 +30,7 @@ import { fullFormats } from './formats'
 import type { CookieOptions } from './cookies'
 import { ValidationError } from './error'
 import type { MaybeArray } from './types'
+import { hasTransform } from './compose'
 
 const isISO8601 =
 	/(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d\.\d+([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))/
@@ -619,7 +620,8 @@ export const ElysiaType = {
 
 				if (typeof value === 'string') return decode(value)
 
-				throw new ValidationError('property', schema, value)
+				// Is probably transformed, unable to check schema
+				return value
 			})
 			.Encode((value) => {
 				if (typeof value === 'string')

src/utils.ts

@@ -366,7 +366,7 @@ const _replaceSchemaType = (
 		const { anyOf, oneOf, allOf, not, properties, items, ...rest } = schema
 		const to = options.to(rest)
 
-		if(!to) return schema
+		if (!to) return schema
 
 		// If t.Transform is used, we need to re-calculate Encode, Decode
 		let transform
@@ -513,7 +513,7 @@ const _replaceSchemaType = (
 					const { anyOf, oneOf, allOf, not, type, ...rest } = value
 					const to = options.to(rest)
 
-					if(!to) return schema
+					if (!to) return schema
 
 					if (to.anyOf)
 						for (let i = 0; i < to.anyOf.length; i++)

test/validator/query.test.ts

@@ -919,4 +919,33 @@ describe('Query Validator', () => {
 			{ status: ['a', 'b'] }
 		])
 	})
+
+	it('handle Transform query', async () => {
+		const app = new Elysia().get(
+			'/test',
+			({ query: { id } }) => ({
+				id,
+				type: typeof id
+			}),
+			{
+				query: t.Object({
+					id: t
+						.Transform(t.Array(t.UnionEnum(['test', 'foo'])))
+						.Decode((id) => ({ value: id }))
+						.Encode((id) => id.value)
+				})
+			}
+		)
+
+		const response = await app
+			.handle(req('/test?id=test'))
+			.then((x) => x.json())
+
+		expect(response).toEqual({
+			id: {
+				value: ['test']
+			},
+			type: 'object'
+		})
+	})
 })