Skip to content

Commit 46d04a9

Browse files
authored
Apply suggestions from code review
1 parent 1d536c1 commit 46d04a9

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

lib/elixir/lib/option_parser.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,7 @@ defmodule OptionParser do
900900
type = get_type(option, opts, types)
901901

902902
with :regex <- type,
903-
{:error, {reason, position}} <- Regex.compile(value) do
903+
{:error, {reason, position}} <- Regex.compile(value, "u") do
904904
"#{option} : Invalid regular expression #{inspect(value)}: #{reason} at position #{position}"
905905
else
906906
_ -> "#{option} : Expected type #{type}, got #{inspect(value)}"

lib/elixir/test/elixir/option_parser_test.exs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -409,20 +409,6 @@ defmodule OptionParserTest do
409409

410410
assert OptionParser.parse(["--pattern", "(?invalid)"], opts) ==
411411
{[], [], [{"--pattern", "(?invalid)"}]}
412-
413-
# Valid regex patterns should compile successfully
414-
assert {[pattern: regex], [], []} =
415-
OptionParser.parse(["--pattern", "valid.*pattern"], opts)
416-
417-
assert Regex.match?(regex, "valid test pattern")
418-
refute Regex.match?(regex, "invalid")
419-
420-
# Test complex valid patterns
421-
assert {[pattern: regex], [], []} =
422-
OptionParser.parse(["--pattern", "\\d{3}-\\d{2}-\\d{4}"], opts)
423-
424-
assert Regex.match?(regex, "123-45-6789")
425-
refute Regex.match?(regex, "abc-de-fghi")
426412
end
427413

428414
test "parse! raises an exception for invalid regex patterns" do

lib/mix/lib/mix/tasks/test.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ defmodule Mix.Tasks.Test do
157157
* `--max-requires` - sets the maximum number of test files to compile in parallel.
158158
Setting this to 1 will compile test files sequentially.
159159
160-
* `-t`, `--name-pattern` *(since v1.19.0)* - only run tests which the name match
160+
* `-n`, `--name-pattern` *(since v1.19.0)* - only run tests which the name matching
161161
the given regular expression
162162
163163
* `--no-archives-check` - does not check archives

0 commit comments

Comments
 (0)