chore: upgrade to Yarn v4 (#1835)

erickzhao · web-flow · commit 2f4d007ee1e1 · 2025-10-02T14:11:43.000-07:00
* chore: upgrade to Yarn v4

* disable scripts and add minimum age gate

* ci fixes

* yarnPath

* ignore install state

* better gitignore

* update yarnrc.yml

* additional "plz don't install" measures

* missing-fixtures

* update asar hash
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -19,7 +19,7 @@ jobs:
         with:
           node-version-file: '.nvmrc'
       - name: Install dependencies
-        run: yarn --frozen-lockfile
+        run: yarn --immutable
       - name: Build API documentation
         run: yarn build:docs
       - name: Azure login
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -27,7 +27,7 @@ jobs:
           node-version-file: .nvmrc
           cache: 'yarn'
       - name: Install
-        run: yarn install --frozen-lockfile
+        run: yarn install --immutable
       - uses: continuousauth/action@4e8a2573eeb706f6d7300d6a9f3ca6322740b72d # v1.0.5
         timeout-minutes: 60
         with:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -28,11 +28,10 @@ jobs:
         uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
           node-version: '${{ matrix.node-version }}'
-          cache: 'yarn'
       - name: Setup CI Environment
         run: test/ci/before_install.sh
       - name: Install
-        run: yarn install --frozen-lockfile
+        run: yarn install --immutable
       - name: Build
         run: yarn build
       - name: Electron Cache
diff --git a/.gitignore b/.gitignore
@@ -15,3 +15,12 @@ typedoc
 npm-debug.log
 dist/
 .eslintcache
+
+# yarn v4
+.pnp.*
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
diff --git a/.yarn/releases/yarn-4.10.2.cjs b/.yarn/releases/yarn-4.10.2.cjs
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -0,0 +1,11 @@
+enableScripts: false
+
+nodeLinker: node-modules
+
+# 1 week
+npmMinimalAgeGate: 10080
+
+npmPreapprovedPackages:
+  - "@electron/*"
+
+yarnPath: .yarn/releases/yarn-4.10.2.cjs
diff --git a/package.json b/package.json
@@ -43,7 +43,6 @@
     "junk": "^4.0.1",
     "parse-author": "^2.0.0",
     "plist": "^3.1.0",
-    "prettier": "^3.6.2",
     "resedit": "^2.0.3",
     "resolve": "^1.22.10",
     "semver": "^7.7.2",
@@ -70,6 +69,7 @@
     "husky": "^9.1.7",
     "lint-staged": "^16.1.5",
     "lodash": "^4.17.21",
+    "prettier": "^3.6.2",
     "tsx": "^4.20.4",
     "typedoc": "~0.25.4",
     "typescript": "^5.9.2",
@@ -108,5 +108,6 @@
       "prettier --write",
       "eslint --fix"
     ]
-  }
+  },
+  "packageManager": "yarn@4.10.2"
 }
diff --git a/test/fixtures/asar-prebuilt/package.json b/test/fixtures/asar-prebuilt/package.json
@@ -4,6 +4,7 @@
   "description": "A prebuilt asar app",
   "main": "main.js",
   "devDependencies": {
-    "electron": "27.0.0"
+    "electron": "27.0.0",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/basic/node_modules/@electron/this-will-never-exist/package.json b/test/fixtures/basic/node_modules/@electron/this-will-never-exist/package.json
diff --git a/test/fixtures/basic/package.json b/test/fixtures/basic/package.json
@@ -12,6 +12,7 @@
     "ncp": "^2.0.0",
     "run-waterfall": "^1.1.1",
     "electron": "27.0.0",
-    "ffi-napi": "4.0.3"
+    "ffi-napi": "4.0.3",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/electron-in-dependencies/node_modules/@electron/this-will-never-exist/package.json b/test/fixtures/electron-in-dependencies/node_modules/@electron/this-will-never-exist/package.json
diff --git a/test/fixtures/electron-in-dependencies/package.json b/test/fixtures/electron-in-dependencies/package.json
@@ -3,6 +3,7 @@
   "productName": "MainJS",
   "description": "Removing electron from dependencies",
   "dependencies": {
-    "electron": "27.0.0"
+    "electron": "27.0.0",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/infer-electron-nightly/node_modules/@electron/this-will-never-exist/package.json b/test/fixtures/infer-electron-nightly/node_modules/@electron/this-will-never-exist/package.json
diff --git a/test/fixtures/infer-electron-nightly/package.json b/test/fixtures/infer-electron-nightly/package.json
@@ -2,6 +2,7 @@
   "main": "main.js",
   "productName": "MainJS",
   "devDependencies": {
-    "electron-nightly": "5.0.0-nightly.20190107"
+    "electron-nightly": "5.0.0-nightly.20190107",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/infer-missing-electron-version/package.json b/test/fixtures/infer-missing-electron-version/package.json
@@ -2,6 +2,7 @@
   "name": "Missing electron version",
   "version": "0.0.1",
   "dependencies": {
-    "run-series": "^1.1.1"
+    "run-series": "^1.1.1",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/infer-missing-name/package.json b/test/fixtures/infer-missing-name/package.json
@@ -1,6 +1,7 @@
 {
   "dependencies": {
     "electron": "6.0.0",
-    "run-series": "^1.1.1"
+    "run-series": "^1.1.1",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/infer-missing-version-only/node_modules/@electron/this-will-never-exist/package.json b/test/fixtures/infer-missing-version-only/node_modules/@electron/this-will-never-exist/package.json
diff --git a/test/fixtures/infer-missing-version-only/package.json b/test/fixtures/infer-missing-version-only/package.json
@@ -2,6 +2,7 @@
   "main": "main.js",
   "productName": "MainJS",
   "devDependencies": {
-    "electron": "27.0.0"
+    "electron": "27.0.0",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/fixtures/infer-win32metadata/package.json b/test/fixtures/infer-win32metadata/package.json
@@ -4,6 +4,7 @@
   "author": "Foo Bar <foo.bar@example.com>",
   "description": "Some description",
   "devDependencies": {
-    "electron": "1.4.15"
+    "electron": "1.4.15",
+    "@electron/this-will-never-exist": "1.0.0"
   }
 }
diff --git a/test/packager.spec.ts b/test/packager.spec.ts
@@ -1347,7 +1347,7 @@ describe('packager', () => {
         expect(infoPlist.ElectronAsarIntegrity).toEqual({
           'Resources/app.asar': {
             algorithm: 'SHA256',
-            hash: 'f4a18a4219d839f07a75a4e93d18f410b020d339c4fe8b5b25a9b380515ef71c',
+            hash: 'e60d812babe8808d3a68572e4d55cc1a2bbde470d9926eafa6b7ea7f86a59767',
           },
         });
       });
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`"description": "A prebuilt asar app",`
`5`	`5`	`"main": "main.js",`
`6`	`6`	`"devDependencies": {`
`7`		`- "electron": "27.0.0"`
	`7`	`+ "electron": "27.0.0",`
	`8`	`+ "@electron/this-will-never-exist": "1.0.0"`
`8`	`9`	`}`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`"ncp": "^2.0.0",`
`13`	`13`	`"run-waterfall": "^1.1.1",`
`14`	`14`	`"electron": "27.0.0",`
`15`		`- "ffi-napi": "4.0.3"`
	`15`	`+ "ffi-napi": "4.0.3",`
	`16`	`+ "@electron/this-will-never-exist": "1.0.0"`
`16`	`17`	`}`
`17`	`18`	`}`