Skip to content

Commit 2bea0b8

Browse files
refactor: migrate from electron-notarize to @electron/notarize
1 parent b56ea8a commit 2bea0b8

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
[Unreleased]: https://github.com/electron/electron-packager/compare/v17.0.0...main
66

7+
### Changed
8+
9+
* Replaced `electron-notarize` with `@electron/notarize`. The configuration options are unchanged. This migration is purely cosmetic.
10+
711
## [17.0.0]
812

913
[17.0.0]: https://github.com/electron/electron-packager/compare/v16.0.0...v17.0.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@
2828
"dependencies": {
2929
"@electron/asar": "^3.2.1",
3030
"@electron/get": "^2.0.0",
31+
"@electron/notarize": "^1.2.3",
3132
"@electron/osx-sign": "^1.0.1",
3233
"@electron/universal": "^1.3.2",
3334
"cross-spawn-windows-exe": "^1.2.0",
3435
"debug": "^4.0.1",
35-
"electron-notarize": "^1.1.1",
3636
"extract-zip": "^2.0.0",
3737
"filenamify": "^4.1.0",
3838
"fs-extra": "^10.1.0",

src/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
LegacyNotarizeCredentials,
1515
NotaryToolCredentials,
1616
TransporterOptions
17-
} from 'electron-notarize/lib/types';
17+
} from '@electron/notarize/lib/types';
1818
import { SignOptions } from '@electron/osx-sign/dist/esm/types';
1919
import type { makeUniversalApp } from '@electron/universal';
2020

@@ -124,7 +124,7 @@ declare namespace electronPackager {
124124
type OsxSignOptions = Omit<SignOptions, 'app' | 'binaries' | 'platform' | 'version'>;
125125

126126
/**
127-
* See the documentation for [`electron-notarize`](https://npm.im/electron-notarize#method-notarizeopts-promisevoid)
127+
* See the documentation for [`@electron/notarize`](https://npm.im/@electron/notarize#method-notarizeopts-promisevoid)
128128
* for details.
129129
*/
130130
type OsxNotarizeOptions =
@@ -433,7 +433,7 @@ declare namespace electronPackager {
433433
name?: string;
434434
/**
435435
* If present, notarizes macOS target apps when the host platform is macOS and XCode is installed.
436-
* See [`electron-notarize`](https://github.com/electron/electron-notarize#method-notarizeopts-promisevoid)
436+
* See [`@electron/notarize`](https://github.com/electron/notarize#method-notarizeopts-promisevoid)
437437
* for option descriptions, such as how to use `appleIdPassword` safely or obtain an API key.
438438
*
439439
* **Requires the [[osxSign]] option to be set.**

src/mac.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const debug = require('debug')('electron-packager')
66
const fs = require('fs-extra')
77
const path = require('path')
88
const plist = require('plist')
9-
const { notarize } = require('electron-notarize')
9+
const { notarize } = require('@electron/notarize')
1010
const { signApp } = require('@electron/osx-sign')
1111

1212
class MacApp extends App {
@@ -422,7 +422,7 @@ function createSignOpts (properties, platform, app, version, quiet) {
422422
}
423423

424424
function createNotarizeOpts (properties, appBundleId, appPath, quiet) {
425-
// osxNotarize options are handed off to the electron-notarize module, but with a few
425+
// osxNotarize options are handed off to the @electron/notarize module, but with a few
426426
// additions from the main options. The user may think they can pass bundle ID or appPath,
427427
// but they will be ignored.
428428
if (properties.tool !== 'notarytool') {

usage.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ osx-sign (macOS host platform only) Whether to sign the macOS app pack
9292
osx-notarize (macOS host platform only, requires --osx-sign) Whether to notarize the macOS app
9393
packages. You must use dot notation to configure a list of sub-properties, e.g.
9494
--osx-notarize.appleId="[email protected]"
95-
For info on supported values see https://npm.im/electron-notarize#method-notarizeopts-promisevoid
95+
For info on supported values see https://npm.im/@electron/notarize#method-notarizeopts-promisevoid
9696
Properties supported include:
9797
- appleId: should contain your apple ID username / email
9898
- appleIdPassword: should contain the password for the provided apple ID

0 commit comments

Comments
 (0)